Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1396613006: Remove skia::PlatformBitmap. (Closed)

Created:
5 years, 2 months ago by tomhudson
Modified:
5 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org, Justin Novosad, _cary
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The *only* client of PlatformBitmap was a video capture unit test which said in a comment that an SkBitmap would do just as well. R=djsollen@chromium.org,miu@chromium.org CC=senorblanco@chromium.org,junov@chromium.org Committed: https://crrev.com/63fedf99b5c887ea15ae1e6a833ff95646ff5cca Cr-Commit-Position: refs/heads/master@{#353941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -192 lines) Patch
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M skia/ext/bitmap_platform_device_cairo.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.h View 1 chunk +0 lines, -6 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 chunk +0 lines, -28 lines 0 comments Download
M skia/ext/platform_canvas.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 27 (10 generated)
tomhudson
Stephen, Justin, there was a comment from a CL you wrote/reviewed years ago in skia/ext/bitmap_platform_device_win.h ...
5 years, 2 months ago (2015-10-13 17:32:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396613006/1
5 years, 2 months ago (2015-10-13 17:38:26 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 2 months ago (2015-10-13 17:38:28 UTC) #5
Tom Hudson
self-LGTM to make the CQ happy, not to actually land...
5 years, 2 months ago (2015-10-13 17:44:21 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396613006/1
5 years, 2 months ago (2015-10-13 17:57:40 UTC) #9
Tom Hudson
5 years, 2 months ago (2015-10-13 19:09:14 UTC) #10
Justin Novosad
On 2015/10/13 19:09:14, Tom Hudson wrote: We used to need platform bitmaps so that skia ...
5 years, 2 months ago (2015-10-13 19:15:56 UTC) #11
Stephen White
On 2015/10/13 17:32:54, tomhudson wrote: > Stephen, Justin, there was a comment from a CL ...
5 years, 2 months ago (2015-10-13 19:17:02 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-13 19:19:03 UTC) #15
bungeman-chromium
On 2015/10/13 19:17:02, Stephen White wrote: > On 2015/10/13 17:32:54, tomhudson wrote: > > Stephen, ...
5 years, 2 months ago (2015-10-13 19:35:24 UTC) #16
bungeman-chromium
lgtm
5 years, 2 months ago (2015-10-13 19:37:03 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396613006/1
5 years, 2 months ago (2015-10-13 19:57:28 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/109033)
5 years, 2 months ago (2015-10-13 20:12:27 UTC) #22
miu
content/browser/media/capture/web_contents_video_capture_device_unittest.cc lgtm
5 years, 2 months ago (2015-10-14 01:56:23 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396613006/1
5 years, 2 months ago (2015-10-14 01:57:41 UTC) #25
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 02:15:06 UTC) #26
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 02:16:37 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63fedf99b5c887ea15ae1e6a833ff95646ff5cca
Cr-Commit-Position: refs/heads/master@{#353941}

Powered by Google App Engine
This is Rietveld 408576698