Remove skia::PlatformBitmap.

The *only* client of PlatformBitmap was a video capture unit test which said in a comment that an SkBitmap would do just as well.

R=djsollen@chromium.org,miu@chromium.org
CC=senorblanco@chromium.org,junov@chromium.org

Committed: https://crrev.com/63fedf99b5c887ea15ae1e6a833ff95646ff5cca
Cr-Commit-Position: refs/heads/master@{#353941}

[tomhudson, 2015-10-13 17:31:42]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[tomhudson, 2015-10-13 17:32:54]

Stephen, Justin, there was a comment from a CL you wrote/reviewed years ago in
skia/ext/bitmap_platform_device_win.h trying to track the lifetime of GDI
bitmaps. It's clearly out of date, but if either of you can shed insight into
the *current actual* management of those it'd be useful.

[commit-bot: I haz the power, 2015-10-13 17:38:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1396613006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1396613006/1

[commit-bot: I haz the power, 2015-10-13 17:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-13 17:38:28]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Tom Hudson, 2015-10-13 17:44:20]

tomhudson@chromium.org changed reviewers:
+ tomhudson@chromium.org

[Tom Hudson, 2015-10-13 17:44:21]

self-LGTM to make the CQ happy, not to actually land...

[Tom Hudson, 2015-10-13 17:44:27]

The CQ bit was checked by tomhudson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-13 17:57:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1396613006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1396613006/1

[Justin Novosad, 2015-10-13 19:15:56]

On 2015/10/13 19:09:14, Tom Hudson wrote:

We used to need platform bitmaps so that skia could draw text and platform
widgets (form buttons, for example). But all of that has been refactored since
then, so we no longer need this code.

lgtm

[Stephen White, 2015-10-13 19:16:25]

senorblanco@chromium.org changed reviewers:
- tomhudson@chromium.org

[Stephen White, 2015-10-13 19:17:02]

On 2015/10/13 17:32:54, tomhudson wrote:
> Stephen, Justin, there was a comment from a CL you wrote/reviewed years ago in
> skia/ext/bitmap_platform_device_win.h trying to track the lifetime of GDI
> bitmaps. It's clearly out of date, but if either of you can shed insight into
> the *current actual* management of those it'd be useful.

I *think* we only use plain SkBitmaps (or SkImages) nowadays, and don't use GDI
for
drawing ClearType fonts anymore (which was the reason we needed GDI, IIRC).
Skia now emulates the Windows stuff internally. Ask bungeman@ to verify. 
ff so, that comment is likely stale.

[commit-bot: I haz the power, 2015-10-13 19:19:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-13 19:19:03]

Dry run: This issue passed the CQ dry run.

[bungeman-chromium, 2015-10-13 19:35:24]

On 2015/10/13 19:17:02, Stephen White wrote:
> On 2015/10/13 17:32:54, tomhudson wrote:
> > Stephen, Justin, there was a comment from a CL you wrote/reviewed years ago
in
> > skia/ext/bitmap_platform_device_win.h trying to track the lifetime of GDI
> > bitmaps. It's clearly out of date, but if either of you can shed insight
into
> > the *current actual* management of those it'd be useful.
> 
> I *think* we only use plain SkBitmaps (or SkImages) nowadays, and don't use
GDI
> for
> drawing ClearType fonts anymore (which was the reason we needed GDI, IIRC).
> Skia now emulates the Windows stuff internally. Ask bungeman@ to verify. 
> ff so, that comment is likely stale.

Skia has been doing ClearType with GDI for a long time now (internally it draws
to its own DIB and extracts the mask from that). I think the
bitmap_platform_device existed mostly to draw native components like scroll bars
and buttons.

[bungeman-chromium, 2015-10-13 19:37:03]

bungeman@chromium.org changed reviewers:
+ bungeman@chromium.org

[bungeman-chromium, 2015-10-13 19:37:03]

lgtm

[tomhudson, 2015-10-13 19:55:59]

The CQ bit was checked by tomhudson@google.com

[commit-bot: I haz the power, 2015-10-13 19:57:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1396613006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1396613006/1

[commit-bot: I haz the power, 2015-10-13 20:12:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-13 20:12:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[miu, 2015-10-14 01:56:23]

content/browser/media/capture/web_contents_video_capture_device_unittest.cc lgtm

[miu, 2015-10-14 01:56:30]

The CQ bit was checked by miu@chromium.org

[commit-bot: I haz the power, 2015-10-14 01:57:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1396613006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1396613006/1

[commit-bot: I haz the power, 2015-10-14 02:15:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-14 02:16:37]

Patchset 1 (id:??) landed as
https://crrev.com/63fedf99b5c887ea15ae1e6a833ff95646ff5cca
Cr-Commit-Position: refs/heads/master@{#353941}