Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139653005: IDL compiler: sync Python to r166626 (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

IDL compiler: sync Python to r166626 Python side to: Move encoding module to oilpan https://codereview.chromium.org/156453002 Also refactoring of local variables into template contents. BUG=239771 TBR=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166665

Patch Set 1 #

Patch Set 2 : Refactored #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M Source/bindings/scripts/unstable/v8_interface.py View 1 2 chunks +12 lines, -6 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-02-07 00:57:51 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-07 00:57:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/139653005/30001
6 years, 10 months ago (2014-02-07 00:58:23 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 00:58:52 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 10 months ago (2014-02-07 00:58:53 UTC) #5
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-07 00:59:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/139653005/30001
6 years, 10 months ago (2014-02-07 00:59:27 UTC) #7
commit-bot: I haz the power
Change committed as 166665
6 years, 10 months ago (2014-02-07 00:59:50 UTC) #8
haraken
6 years, 10 months ago (2014-02-07 01:08:28 UTC) #9
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698