third_party/WebKit/Source/core/layout/LayoutTableSection.cpp - Issue 1396493005: Table rowspan cell's height resize when percent element present in the cell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 1396493005: Table rowspan cell's height resize when percent element present in the cell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed Layout test and expectation Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue.html ('K') | « third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

index afb1424af20b17dd535baaf7b8b72eb90a7b5c23..3a608f82773b699e561bfed3ce079dc761b6c18d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

@@ -763,6 +763,12 @@ int LayoutTableSection::calcRowLogicalHeight()

rowSpanCells.append(cell);

lastRowSpanCell = cell;

+ if (cell->hasOverrideLogicalContentHeight()) {

+ cell->clearIntrinsicPadding();

+ cell->clearOverrideSize();

+ cell->forceChildLayout();

+ }

// Find out the baseline. The baseline is set on the first row in a rowSpan.

updateBaselineForCell(cell, r, baselineDescent);

}