Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue.html

Issue 1396493005: Table rowspan cell's height resize when percent element present in the cell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed Layout test and expectation Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue.html
diff --git a/third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue.html b/third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue.html
new file mode 100644
index 0000000000000000000000000000000000000000..8d276367cc30addf8fbf48e3c61d4623941065fa
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<style>
+ td { font: 15px/1 Ahem }
+</style>
+<script src="../../resources/check-layout.js"></script>
+<script>
+setTimeout(function() {
+ funcToRunAfterUIUpdate()
+}, 0);
+
+function funcToRunAfterUIUpdate()
mstensho (USE GERRIT) 2015/12/04 14:10:10 Instead of this machinery (setTimeout, funcToRunAf
a.suchit2 2016/01/08 14:12:50 I am able to move the checkLayout() after the DOM
mstensho (USE GERRIT) 2016/01/08 19:22:10 I actually think it's easier if you just upload a
a.suchit2 2016/01/11 12:57:17 I am able to do it. Fixed all review comments. tha
+{
+ document.getElementById("ta").rowSpan=2;
mstensho (USE GERRIT) 2015/12/04 14:10:10 I cannot find any element named #ta. Simply resizi
a.suchit2 2016/01/08 14:12:50 sorry for mistake. I needs to add for text area td
+}
+</script>
+<body onload="checkLayout('tr');">
mstensho (USE GERRIT) 2015/12/04 14:10:10 Can you do checkLayout("table") instead? checkLayo
a.suchit2 2016/01/08 14:12:50 checklayout("table") can be used. Thanks
+ <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=445253">445253</a>. Setting rowspan=2 on the table cell causes the whole table to resize again and again.</h3>
+ <table border="1">
+ <tr data-expected-height="20">
+ <td/>
+ <td rowspan="2"><textarea style='height:100%;'>Text area text</textarea></td>
+ </tr>
+ <tr data-expected-height="21">
+ <td/>
+ <td></td>
+ </tr>
+ </table>
+</body>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698