third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue.html - Issue 1396493005: Table rowspan cell's height resize when percent element present in the cell.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue.html

Issue 1396493005: Table rowspan cell's height resize when percent element present in the cell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed Layout test and expectation Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/table/table-rowspan-cell-override-logical-content-height-reset-issue-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 td { font: 15px/1 Ahem }

	4 </style>

	5 <script src="../../resources/check-layout.js"></script>

	6 <script>

	7 setTimeout(function() {

	8 funcToRunAfterUIUpdate()

	9 }, 0);

	10

	11 function funcToRunAfterUIUpdate()
	mstensho (USE GERRIT) 2015/12/04 14:10:10 Instead of this machinery (setTimeout, funcToRunAf Instead of this machinery (setTimeout, funcToRunAfterUIUpdate), couldn't you just add a script at the end of the document that does document.body.offsetTop to trigger layout, followed by the DOM change that you want to do, followed by checkLayout() (instead of doing it via body onload)? a.suchit2 2016/01/08 14:12:50 I am able to move the checkLayout() after the DOM Show quoted text On 2015/12/04 14:10:10, mstensho wrote: > Instead of this machinery (setTimeout, funcToRunAfterUIUpdate), couldn't you > just add a script at the end of the document that does document.body.offsetTop > to trigger layout, followed by the DOM change that you want to do, followed by > checkLayout() (instead of doing it via body onload)? I am able to move the checkLayout() after the DOM changes but I did not get how to do the re-layout trigger method just using document.body.offsetTop in the script added in the end. Plz help. mstensho (USE GERRIT) 2016/01/08 19:22:10 I actually think it's easier if you just upload a Show quoted text On 2016/01/08 14:12:50, a.suchit2 wrote: > On 2015/12/04 14:10:10, mstensho wrote: > > Instead of this machinery (setTimeout, funcToRunAfterUIUpdate), couldn't you > > just add a script at the end of the document that does document.body.offsetTop > > to trigger layout, followed by the DOM change that you want to do, followed by > > checkLayout() (instead of doing it via body onload)? > > I am able to move the checkLayout() after the DOM changes but I did not get how > to do the re-layout trigger method just using document.body.offsetTop in the > script added in the end. Plz help. I actually think it's easier if you just upload a new patch set with what you have, even if it doesn't work. Maybe then I can figure out what this is about. a.suchit2 2016/01/11 12:57:17 I am able to do it. Fixed all review comments. tha Show quoted text On 2016/01/08 19:22:10, mstensho wrote: > On 2016/01/08 14:12:50, a.suchit2 wrote: > > On 2015/12/04 14:10:10, mstensho wrote: > > > Instead of this machinery (setTimeout, funcToRunAfterUIUpdate), couldn't you > > > just add a script at the end of the document that does > document.body.offsetTop > > > to trigger layout, followed by the DOM change that you want to do, followed > by > > > checkLayout() (instead of doing it via body onload)? > > > > I am able to move the checkLayout() after the DOM changes but I did not get > how > > to do the re-layout trigger method just using document.body.offsetTop in the > > script added in the end. Plz help. > > I actually think it's easier if you just upload a new patch set with what you > have, even if it doesn't work. Maybe then I can figure out what this is about. I am able to do it. Fixed all review comments. thanks
	12 {

	13 document.getElementById("ta").rowSpan=2;
	mstensho (USE GERRIT) 2015/12/04 14:10:10 I cannot find any element named #ta. Simply resizi I cannot find any element named #ta. Simply resizing the window causes the table to grow, though, so maybe just setting a new width on the table would suffice to reproduce the bug. a.suchit2 2016/01/08 14:12:50 sorry for mistake. I needs to add for text area td Show quoted text On 2015/12/04 14:10:10, mstensho wrote: > I cannot find any element named #ta. Simply resizing the window causes the table > to grow, though, so maybe just setting a new width on the table would suffice to > reproduce the bug. sorry for mistake. I needs to add for text area td element.
	14 }

	15 </script>

	16 <body onload="checkLayout('tr');">
	mstensho (USE GERRIT) 2015/12/04 14:10:10 Can you do checkLayout("table") instead? checkLayo Can you do checkLayout("table") instead? checkLayout() inserts a block next to the specified objects here, so it will mess up the layout (block next to table-row) for no good reason. a.suchit2 2016/01/08 14:12:50 checklayout("table") can be used. Thanks Show quoted text On 2015/12/04 14:10:10, mstensho wrote: > Can you do checkLayout("table") instead? checkLayout() inserts a block next to > the specified objects here, so it will mess up the layout (block next to > table-row) for no good reason. checklayout("table") can be used. Thanks
	17 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issu es/detail?id=445253">445253</a>. Setting rowspan=2 on the table cell causes the whole table to resize again and again.</h3>

	18 <table border="1">

	19 <tr data-expected-height="20">

	20 <td/>

	21 <td rowspan="2"><textarea style='height:100%;'>Text area text</texta rea></td>

	22 </tr>

	23 <tr data-expected-height="21">

	24 <td/>

	25 <td></td>

	26 </tr>

	27 </table>

	28 </body>

OLD	NEW