Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139643005: Don't free id before accessing it. (Closed)

Created:
6 years, 10 months ago by Marijn Kruisselbrink
Modified:
6 years, 10 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Don't free id before accessing it. BUG=338164 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/updater/extension_downloader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Marijn Kruisselbrink
There doesn't seem to be a particular reason you reordered these two lines?
6 years, 10 months ago (2014-01-28 19:12:19 UTC) #1
Marijn Kruisselbrink
There doesn't seem to be a particular reason you reordered these two lines?
6 years, 10 months ago (2014-01-28 19:12:52 UTC) #2
Dmitry Polukhin
LGTM Opps, I didn't notice this side effect of my change.
6 years, 10 months ago (2014-01-28 19:15:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/139643005/1
6 years, 10 months ago (2014-01-28 19:19:13 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-28 21:14:17 UTC) #5
Message was sent while issue was closed. 
Change committed as 247503

Powered by Google App Engine
This is Rietveld 408576698