chrome/browser/extensions/updater/extension_downloader.cc - Issue 139643005: Don't free id before accessing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_downloader.cc

Issue 139643005: Don't free id before accessing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/updater/extension_downloader.cc

diff --git a/chrome/browser/extensions/updater/extension_downloader.cc b/chrome/browser/extensions/updater/extension_downloader.cc

index a49068a818264b941e095a8e0a0f358a4ecab1c0..8bfe5c00cc7381a8b6a86cb09faef2842c17270b 100644

--- a/chrome/browser/extensions/updater/extension_downloader.cc

+++ b/chrome/browser/extensions/updater/extension_downloader.cc

@@ -721,8 +721,8 @@ void ExtensionDownloader::OnCRXFetchComplete(

delegate_->OnExtensionDownloadFailed(

id, ExtensionDownloaderDelegate::CRX_FETCH_FAILED, ping, request_ids);

}

- extensions_queue_.reset_active_request();

ping_results_.erase(id);

+ extensions_queue_.reset_active_request();

}

extension_fetcher_.reset();

« no previous file with comments | « no previous file | no next file » | no next file with comments »