Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1396423002: Move //mojo/services/network/public/interfaces to //mojo/services/network/interfaces. (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/monet.git@master
Target Ref:
refs/heads/master
Project:
monet
Visibility:
Public.

Description

Move //mojo/services/network/public/interfaces to //mojo/services/network/interfaces. And also //mojo/services/network/public/cpp/*.{cc,h} to //mojo/services/network (the code isn't used anywhere else -- not even in a bastardized copy -- and has bad dependencies, e.g., on //base). Note that the mojom files aren't actually in a state to be consumed externally (easily), since they hard-code a "third_party" directory in various imports. R=jamesr@chromium.org Committed: https://github.com/domokit/monet8f93f7fed6721b934196e56f7c06e7fb3a12d91b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -1445 lines) Patch
M mojo/services/network/BUILD.gn View 3 chunks +11 lines, -6 lines 0 comments Download
M mojo/services/network/cookie_store_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/host_resolver_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/network/host_resolver_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/http_connection_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/network/http_connection_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/network/http_server_apptest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M mojo/services/network/http_server_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/network/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/interfaces/cookie_store.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/interfaces/host_resolver.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/interfaces/http_connection.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/network/interfaces/http_message.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/interfaces/http_server.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/interfaces/net_address.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/interfaces/network_service.mojom View 1 chunk +10 lines, -10 lines 0 comments Download
A + mojo/services/network/interfaces/tcp_bound_socket.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/network/interfaces/tcp_connected_socket.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/interfaces/tcp_server_socket.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/network/interfaces/udp_socket.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/interfaces/url_loader.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/interfaces/url_loader_interceptor.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/interfaces/web_socket.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/services/network/net_address_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/network_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/network/public/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/services/network/public/cpp/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/services/network/public/cpp/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/services/network/public/cpp/udp_socket_wrapper.h View 1 chunk +0 lines, -182 lines 0 comments Download
D mojo/services/network/public/cpp/udp_socket_wrapper.cc View 1 chunk +0 lines, -242 lines 0 comments Download
D mojo/services/network/public/cpp/web_socket_read_queue.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/services/network/public/cpp/web_socket_read_queue.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D mojo/services/network/public/cpp/web_socket_write_queue.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/services/network/public/cpp/web_socket_write_queue.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D mojo/services/network/public/interfaces/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/services/network/public/interfaces/cookie_store.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/services/network/public/interfaces/host_resolver.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/network/public/interfaces/http_connection.mojom View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/services/network/public/interfaces/http_message.mojom View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/services/network/public/interfaces/http_server.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/network/public/interfaces/net_address.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/services/network/public/interfaces/network_service.mojom View 1 chunk +0 lines, -86 lines 0 comments Download
D mojo/services/network/public/interfaces/tcp_bound_socket.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/services/network/public/interfaces/tcp_connected_socket.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/network/public/interfaces/tcp_server_socket.mojom View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/services/network/public/interfaces/udp_socket.mojom View 1 chunk +0 lines, -120 lines 0 comments Download
D mojo/services/network/public/interfaces/url_loader.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/services/network/public/interfaces/url_loader_interceptor.mojom View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/services/network/public/interfaces/web_socket.mojom View 1 chunk +0 lines, -59 lines 0 comments Download
M mojo/services/network/tcp_bound_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_server_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/network/udp_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/udp_socket_wrapper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/network/udp_socket_wrapper.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M mojo/services/network/url_loader_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/network/url_loader_interceptor_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/web_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/web_socket_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/network/web_socket_read_queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/network/web_socket_read_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/web_socket_write_queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/network/web_socket_write_queue.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 2 months ago (2015-10-12 23:43:14 UTC) #1
viettrungluu
I'll try to make the interfaces actually "exportable" (without modifying import statements) separately.
5 years, 2 months ago (2015-10-12 23:45:35 UTC) #2
jamesr
lgtm
5 years, 2 months ago (2015-10-12 23:46:20 UTC) #3
viettrungluu
5 years, 2 months ago (2015-10-12 23:52:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f93f7fed6721b934196e56f7c06e7fb3a12d91b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698