Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 1396283004: Revert of [x64] Use vcvtlsi2sd when AVX is enabled (Closed)

Created:
5 years, 2 months ago by alph
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [x64] Use vcvtlsi2sd when AVX is enabled (patchset #1 id:1 of https://codereview.chromium.org/1404903004/ ) Reason for revert: Caused a crash on Windows Original issue's description: > [x64] Use vcvtlsi2sd when AVX is enabled > > BUG=v8:4406 > LOG=N > > Committed: https://crrev.com/adcbe619a959fe1d8f21d06fbf5984868c4f6b9a > Cr-Commit-Position: refs/heads/master@{#31276} TBR=bmeurer@chromium.org,danno@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4406 Committed: https://crrev.com/ad1e05704967ad336887edd8942e5d158f91d3f8 Cr-Commit-Position: refs/heads/master@{#31277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -43 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +4 lines, -16 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alph
Created Revert of [x64] Use vcvtlsi2sd when AVX is enabled
5 years, 2 months ago (2015-10-15 06:08:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396283004/1
5 years, 2 months ago (2015-10-15 06:08:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 06:08:35 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 06:09:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad1e05704967ad336887edd8942e5d158f91d3f8
Cr-Commit-Position: refs/heads/master@{#31277}

Powered by Google App Engine
This is Rietveld 408576698