Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chrome/browser/ui/search/search_tab_helper.h

Issue 1396143002: Emit correct NewTabPage.SuggestionsType metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search/instant_service_unittest.cc ('k') | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/search_tab_helper.h
diff --git a/chrome/browser/ui/search/search_tab_helper.h b/chrome/browser/ui/search/search_tab_helper.h
index 0db812788c6fb8edd5478b05ac99fc4ffd33b2c2..9af08dd39cbb02b1d16bcdb6f36c052c8eb4e436 100644
--- a/chrome/browser/ui/search/search_tab_helper.h
+++ b/chrome/browser/ui/search/search_tab_helper.h
@@ -128,6 +128,10 @@ class SearchTabHelper : public content::WebContentsObserver,
OnHistorySyncCheckSyncing);
FRIEND_TEST_ALL_PREFIXES(SearchTabHelperTest,
OnHistorySyncCheckNotSyncing);
+ FRIEND_TEST_ALL_PREFIXES(SearchTabHelperTest,
+ OnMostVisitedItemsChangedFromServer);
+ FRIEND_TEST_ALL_PREFIXES(SearchTabHelperTest,
+ OnMostVisitedItemsChangedFromClient);
FRIEND_TEST_ALL_PREFIXES(SearchIPCRouterTest,
IgnoreMessageIfThePageIsNotActive);
FRIEND_TEST_ALL_PREFIXES(SearchIPCRouterTest,
@@ -205,6 +209,10 @@ class SearchTabHelper : public content::WebContentsObserver,
// Returns the OmniboxView for |web_contents_| or NULL if not available.
OmniboxView* GetOmniboxView() const;
+ // Record whether each suggestion comes from server or client.
+ void LogMostVisitedItemsSource(
+ const std::vector<InstantMostVisitedItem>& items);
+
typedef bool (*OmniboxHasFocusFn)(OmniboxView*);
void set_omnibox_has_focus_fn(OmniboxHasFocusFn fn) {
« no previous file with comments | « chrome/browser/search/instant_service_unittest.cc ('k') | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698