Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/browser/search/instant_service_unittest.cc

Issue 1396143002: Emit correct NewTabPage.SuggestionsType metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search/instant_service.cc ('k') | chrome/browser/ui/search/search_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search/instant_service_unittest.cc
diff --git a/chrome/browser/search/instant_service_unittest.cc b/chrome/browser/search/instant_service_unittest.cc
index 4b5d0f7d5916c174bbacf25ae09f3ddb229cefbb..4b5f0f77da51b7aee1213d727bc40238d979234c 100644
--- a/chrome/browser/search/instant_service_unittest.cc
+++ b/chrome/browser/search/instant_service_unittest.cc
@@ -165,3 +165,25 @@ TEST_F(InstantServiceTest, OmniboxStartMarginChanged) {
OmniboxStartMarginChanged(new_start_margin)).Times(1);
UpdateOmniboxStartMargin(new_start_margin);
}
+
+TEST_F(InstantServiceTest, GetSuggestionFromServiceSide) {
+ auto profile = suggestions::SuggestionsProfile();
+ profile.add_suggestions();
+
+ instant_service_->OnSuggestionsAvailable(profile);
+
+ auto items = instant_service_->suggestions_items_;
+ ASSERT_EQ(1, (int)items.size());
+ ASSERT_TRUE(items[0].is_server_side_suggestion);
+}
+
+TEST_F(InstantServiceTest, GetSuggestionFromClientSide) {
+ history::MostVisitedURLList url_list;
+ url_list.push_back(history::MostVisitedURL());
+
+ instant_service_->OnMostVisitedItemsReceived(url_list);
+
+ auto items = instant_service_->most_visited_items_;
+ ASSERT_EQ(1, (int)items.size());
+ ASSERT_FALSE(items[0].is_server_side_suggestion);
+}
« no previous file with comments | « chrome/browser/search/instant_service.cc ('k') | chrome/browser/ui/search/search_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698