Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 139613005: Support default values for complex objects in mojom. (Closed)

Created:
6 years, 11 months ago by Matt Perry
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Support default values for complex objects in mojom. BUG=320082 R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248579

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -25 lines) Patch
M mojo/apps/js/bindings/sample_service_unittests.js View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
M mojo/public/bindings/generators/cpp_templates/struct_builder_definition.tmpl View 2 1 chunk +38 lines, -15 lines 0 comments Download
M mojo/public/bindings/generators/js_templates/struct_definition.tmpl View 1 chunk +50 lines, -0 lines 0 comments Download
M mojo/public/bindings/generators/mojom_cpp_generator.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/bindings/generators/mojom_js_generator.py View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/bindings/pylib/generate/mojom_generator.py View 1 2 3 2 chunks +18 lines, -0 lines 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_parser.py View 1 2 3 4 5 2 chunks +21 lines, -4 lines 0 comments Download
M mojo/public/bindings/tests/sample_service.mojom View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M mojo/public/bindings/tests/sample_service_unittest.cc View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Matt Perry
Based on https://codereview.chromium.org/141893004/
6 years, 11 months ago (2014-01-23 19:29:42 UTC) #1
Matt Perry
ping
6 years, 10 months ago (2014-01-28 20:34:54 UTC) #2
darin (slow to review)
LGTM
6 years, 10 months ago (2014-01-29 17:51:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/139613005/450001
6 years, 10 months ago (2014-01-29 19:24:14 UTC) #4
commit-bot: I haz the power
Failed to apply patch for mojo/public/bindings/sample/sample_service_unittests.js: While running patch -p1 --forward --force --no-backup-if-mismatch; A mojo/public/bindings/sample ...
6 years, 10 months ago (2014-01-29 19:24:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/139613005/470001
6 years, 10 months ago (2014-01-29 19:32:20 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=47038
6 years, 10 months ago (2014-01-29 20:03:43 UTC) #7
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 10 months ago (2014-02-03 21:18:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/139613005/490001
6 years, 10 months ago (2014-02-03 21:18:17 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 21:37:16 UTC) #10
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=47747
6 years, 10 months ago (2014-02-03 21:37:16 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 21:37:22 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 21:37:26 UTC) #13
Matt Perry
6 years, 10 months ago (2014-02-03 21:40:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #6 manually as r248579 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698