Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Side by Side Diff: mojo/public/bindings/generators/mojom_js_generator.py

Issue 139613005: Support default values for complex objects in mojom. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Generates JavaScript source files from a mojom.Module.""" 5 """Generates JavaScript source files from a mojom.Module."""
6 6
7 from generate import mojom 7 from generate import mojom
8 from generate import mojom_pack 8 from generate import mojom_pack
9 from generate import mojom_generator 9 from generate import mojom_generator
10 10
(...skipping 15 matching lines...) Expand all
26 mojom.MSGPIPE: "core.kInvalidHandle", 26 mojom.MSGPIPE: "core.kInvalidHandle",
27 mojom.INT64: "0", 27 mojom.INT64: "0",
28 mojom.UINT64: "0", 28 mojom.UINT64: "0",
29 mojom.DOUBLE: "0", 29 mojom.DOUBLE: "0",
30 mojom.STRING: '""', 30 mojom.STRING: '""',
31 } 31 }
32 32
33 33
34 def JavaScriptDefaultValue(field): 34 def JavaScriptDefaultValue(field):
35 if field.default: 35 if field.default:
36 if isinstance(field.default, list): 36 raise Exception("Default values should've been handled in jinja.")
37 # TODO(mpcomplete): This will need to be more sophisticated to support
38 # arrays of objects/arrays.
39 return "[" + ", ".join(field.default) + "]"
40 else:
41 return field.default
42 if field.kind in mojom.PRIMITIVES: 37 if field.kind in mojom.PRIMITIVES:
43 return _kind_to_javascript_default_value[field.kind] 38 return _kind_to_javascript_default_value[field.kind]
44 if isinstance(field.kind, mojom.Struct): 39 if isinstance(field.kind, mojom.Struct):
45 return "null"; 40 return "null";
46 if isinstance(field.kind, mojom.Array): 41 if isinstance(field.kind, mojom.Array):
47 return "[]"; 42 return "[]";
48 43
49 44
50 def JavaScriptPayloadSize(packed): 45 def JavaScriptPayloadSize(packed):
51 packed_fields = packed.packed_fields 46 packed_fields = packed.packed_fields
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 return "encodeArrayPointer(%s, " % GetJavaScriptType(kind.kind); 140 return "encodeArrayPointer(%s, " % GetJavaScriptType(kind.kind);
146 141
147 142
148 class Generator(mojom_generator.Generator): 143 class Generator(mojom_generator.Generator):
149 144
150 js_filters = { 145 js_filters = {
151 "default_value": JavaScriptDefaultValue, 146 "default_value": JavaScriptDefaultValue,
152 "payload_size": JavaScriptPayloadSize, 147 "payload_size": JavaScriptPayloadSize,
153 "decode_snippet": JavaScriptDecodeSnippet, 148 "decode_snippet": JavaScriptDecodeSnippet,
154 "encode_snippet": JavaScriptEncodeSnippet, 149 "encode_snippet": JavaScriptEncodeSnippet,
150 "is_object_kind": mojom_generator.IsObjectKind,
151 "is_string_kind": mojom_generator.IsStringKind,
152 "is_array_kind": lambda kind: isinstance(kind, mojom.Array),
153 "struct_by_name": mojom_generator.GetStructByName,
155 "stylize_method": mojom_generator.StudlyCapsToCamel, 154 "stylize_method": mojom_generator.StudlyCapsToCamel,
155 "verify_token_type": mojom_generator.VerifyTokenType,
156 } 156 }
157 157
158 @UseJinja("js_templates/module.js.tmpl", filters=js_filters) 158 @UseJinja("js_templates/module.js.tmpl", filters=js_filters)
159 def GenerateJsModule(self): 159 def GenerateJsModule(self):
160 return { 160 return {
161 "enums": self.module.enums, 161 "enums": self.module.enums,
162 "structs": self.GetStructs() + self.GetStructsFromMethods(), 162 "structs": self.GetStructs() + self.GetStructsFromMethods(),
163 "interfaces": self.module.interfaces, 163 "interfaces": self.module.interfaces,
164 } 164 }
165 165
166 def GenerateFiles(self): 166 def GenerateFiles(self):
167 self.Write(self.GenerateJsModule(), "%s.js" % self.module.name) 167 self.Write(self.GenerateJsModule(), "%s.js" % self.module.name)
OLDNEW
« no previous file with comments | « mojo/public/bindings/generators/mojom_cpp_generator.py ('k') | mojo/public/bindings/pylib/generate/mojom_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698