Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1396053002: Rename <menu type=popup> to <menu type=context>. (Closed)

Created:
5 years, 2 months ago by pals
Modified:
5 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename <menu type=popup> to <menu type=context>. Specification is updated to rename <menu type=popup> to <menu type=context>. https://html.spec.whatwg.org/multipage/forms.html#attr-menu-type BUG=87553 Committed: https://crrev.com/99054b8e300bfb14e68fbb4d9f3c9d6a323f3f49 Cr-Commit-Position: refs/heads/master@{#353624}

Patch Set 1 #

Patch Set 2 : Updated more tests #

Patch Set 3 : rebaselined #

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396053002/1
5 years, 2 months ago (2015-10-09 09:48:33 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/80022) win_chromium_x64_rel_ng on ...
5 years, 2 months ago (2015-10-09 10:34:24 UTC) #4
pals
Please review.
5 years, 2 months ago (2015-10-12 03:57:31 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396053002/20001
5 years, 2 months ago (2015-10-12 03:57:46 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396053002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396053002/40001
5 years, 2 months ago (2015-10-12 05:00:42 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-12 06:10:20 UTC) #12
tkent
lgtm
5 years, 2 months ago (2015-10-12 23:14:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396053002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396053002/40001
5 years, 2 months ago (2015-10-12 23:15:50 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-12 23:23:37 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 23:24:24 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/99054b8e300bfb14e68fbb4d9f3c9d6a323f3f49
Cr-Commit-Position: refs/heads/master@{#353624}

Powered by Google App Engine
This is Rietveld 408576698