third_party/WebKit/Source/core/page/ContextMenuController.cpp - Issue 1396053002: Rename <menu type=popup> to <menu type=context>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ContextMenuController.cpp

Issue 1396053002: Rename <menu type=popup> to <menu type=context>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/ContextMenuController.cpp

diff --git a/third_party/WebKit/Source/core/page/ContextMenuController.cpp b/third_party/WebKit/Source/core/page/ContextMenuController.cpp

index 38585496e7af3b23fbeb69026354ee1aed3a7122..98bb06465d443983afbd39bf55ddd2d7cb3988f2 100644

--- a/third_party/WebKit/Source/core/page/ContextMenuController.cpp

+++ b/third_party/WebKit/Source/core/page/ContextMenuController.cpp

@@ -96,7 +96,7 @@ void ContextMenuController::populateCustomContextMenu(const Event& event)

HTMLElement& element = toHTMLElement(*node);

RefPtrWillBeRawPtr<HTMLMenuElement> menuElement = element.assignedContextMenu();

- if (!menuElement || !equalIgnoringCase(menuElement->fastGetAttribute(typeAttr), "popup"))

+ if (!menuElement || !equalIgnoringCase(menuElement->fastGetAttribute(typeAttr), "context"))

return;

RefPtrWillBeRawPtr<RelatedEvent> relatedEvent = RelatedEvent::create(EventTypeNames::show, true, true, node);

if (!menuElement->dispatchEvent(relatedEvent.release()))