<webview>: Speculative crash fix

<webview>: Speculative crash fix

This CL also does a bit of cleanup moving the WeakPtrFactory to the bottom of the member variables of a couple of BrowserPlugin/webview classes.

BUG=334606
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245275

[sadrul, 2014-01-15 17:04:22]

I think this is the right fix. (I had this crash once, and tried the same fix,
but could not force a test to repro the crash, so it never went out for review)

https://codereview.chromium.org/139603002/diff/1/chrome/browser/guestview/gue...
File chrome/browser/guestview/guestview.h (right):

https://codereview.chromium.org/139603002/diff/1/chrome/browser/guestview/gue...
chrome/browser/guestview/guestview.h:120: base::WeakPtrFactory<GuestView>
weak_ptr_factory_;
This should be at the end
(https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/A9_N8p40l7A)

[Fady Samuel, 2014-01-15 17:34:13]

PTAL

https://codereview.chromium.org/139603002/diff/1/chrome/browser/guestview/gue...
File chrome/browser/guestview/guestview.h (right):

https://codereview.chromium.org/139603002/diff/1/chrome/browser/guestview/gue...
chrome/browser/guestview/guestview.h:120: base::WeakPtrFactory<GuestView>
weak_ptr_factory_;
On 2014/01/15 17:04:22, sadrul wrote:
> This should be at the end
>
(https://groups.google.com/a/chromium.org/forum/#%21topic/chromium-dev/A9_N8p4...)

Done. I've changed a couple of places to match the convention.

[sadrul, 2014-01-15 18:09:24]

lgtm

[sadrul, 2014-01-15 18:10:06]

Mind updating the cl desc too a little to talk about the cleanup?

[commit-bot: I haz the power, 2014-01-15 18:31:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/139603002/50001

[commit-bot: I haz the power, 2014-01-16 19:24:08]

Change committed as 245275