Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 139603002: <webview>: Speculative crash fix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adddressed comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_ 5 #ifndef CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
6 #define CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_ 6 #define CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
7 7
8 #include "third_party/WebKit/public/web/WebPlugin.h" 8 #include "third_party/WebKit/public/web/WebPlugin.h"
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 // Used for HW compositing. 362 // Used for HW compositing.
363 bool compositing_enabled_; 363 bool compositing_enabled_;
364 scoped_refptr<BrowserPluginCompositingHelper> compositing_helper_; 364 scoped_refptr<BrowserPluginCompositingHelper> compositing_helper_;
365 365
366 // Used to identify the plugin to WebBindings. 366 // Used to identify the plugin to WebBindings.
367 scoped_ptr<struct _NPP> npp_; 367 scoped_ptr<struct _NPP> npp_;
368 368
369 // URL for the embedder frame. 369 // URL for the embedder frame.
370 GURL embedder_frame_url_; 370 GURL embedder_frame_url_;
371 371
372 std::vector<EditCommand> edit_commands_;
373
372 // Weak factory used in v8 |MakeWeak| callback, since the v8 callback might 374 // Weak factory used in v8 |MakeWeak| callback, since the v8 callback might
373 // get called after BrowserPlugin has been destroyed. 375 // get called after BrowserPlugin has been destroyed.
374 base::WeakPtrFactory<BrowserPlugin> weak_ptr_factory_; 376 base::WeakPtrFactory<BrowserPlugin> weak_ptr_factory_;
375 377
376 std::vector<EditCommand> edit_commands_;
377
378 DISALLOW_COPY_AND_ASSIGN(BrowserPlugin); 378 DISALLOW_COPY_AND_ASSIGN(BrowserPlugin);
379 }; 379 };
380 380
381 } // namespace content 381 } // namespace content
382 382
383 #endif // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_ 383 #endif // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
OLDNEW
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698