Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: base/message_loop/message_loop.h

Issue 139593002: Nukes MessageLoop::Dispatcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/accelerators/nested_dispatcher_controller_unittest.cc ('k') | base/run_loop.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_loop.h
diff --git a/base/message_loop/message_loop.h b/base/message_loop/message_loop.h
index 59c6cdc40a7a70b7bed33b1e008f4f1474103524..74eddaf2fc9f694bc8368bc7e64f8752a905aaef 100644
--- a/base/message_loop/message_loop.h
+++ b/base/message_loop/message_loop.h
@@ -25,9 +25,8 @@
#include "base/time/time.h"
#include "base/tracking_info.h"
+// TODO(sky): these includes should not be necessary. Nuke them.
#if defined(OS_WIN)
-// We need this to declare base::MessagePumpWin::Dispatcher, which we should
-// really just eliminate.
#include "base/message_loop/message_pump_win.h"
#elif defined(OS_IOS)
#include "base/message_loop/message_pump_io_ios.h"
@@ -53,7 +52,6 @@
namespace base {
class HistogramBase;
-class MessagePumpDispatcher;
class MessagePumpObserver;
class RunLoop;
class ThreadTaskRunnerHandle;
@@ -97,7 +95,6 @@ class BASE_EXPORT MessageLoop : public MessagePump::Delegate {
public:
#if defined(USE_AURA)
- typedef MessagePumpDispatcher Dispatcher;
typedef MessagePumpObserver Observer;
#elif defined(USE_GTK_MESSAGE_PUMP)
typedef MessagePumpGdkObserver Observer;
« no previous file with comments | « ash/accelerators/nested_dispatcher_controller_unittest.cc ('k') | base/run_loop.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698