Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1395923003: Share context creation logic with sync compositor (Closed)

Created:
5 years, 2 months ago by boliu
Modified:
5 years, 2 months ago
Reviewers:
no sievers
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Share context creation logic with sync compositor Other than memory limits, synchronous compositor and regular regular compositor share the same context creation logic. So actually share the code path as well. BUG=526842 Committed: https://crrev.com/853d4605472548374e999bbadaf531fd68234366 Cr-Commit-Position: refs/heads/master@{#353837}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -94 lines) Patch
M content/browser/android/in_process/synchronous_compositor_factory_impl.h View 1 2 3 chunks +3 lines, -7 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 2 3 chunks +3 lines, -77 lines 0 comments Download
M content/renderer/android/synchronous_compositor_factory.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
boliu
wdyt?
5 years, 2 months ago (2015-10-13 15:54:18 UTC) #2
boliu
https://codereview.chromium.org/1395923003/diff/20001/content/browser/android/in_process/synchronous_compositor_factory_impl.h File content/browser/android/in_process/synchronous_compositor_factory_impl.h (right): https://codereview.chromium.org/1395923003/diff/20001/content/browser/android/in_process/synchronous_compositor_factory_impl.h#newcode43 content/browser/android/in_process/synchronous_compositor_factory_impl.h:43: scoped_refptr<content::FrameSwapMessageQueue> frame_swap_message_queue, just realized these are not const&, I'll ...
5 years, 2 months ago (2015-10-13 18:49:09 UTC) #3
no sievers
LGTM https://codereview.chromium.org/1395923003/diff/20001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/1395923003/diff/20001/content/renderer/render_widget.cc#newcode2331 content/renderer/render_widget.cc:2331: // because 16bit texture is not supported. nit: ...
5 years, 2 months ago (2015-10-13 18:52:07 UTC) #4
boliu
all done
5 years, 2 months ago (2015-10-13 19:05:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395923003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395923003/40001
5 years, 2 months ago (2015-10-13 19:07:51 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-13 20:20:14 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 20:20:54 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/853d4605472548374e999bbadaf531fd68234366
Cr-Commit-Position: refs/heads/master@{#353837}

Powered by Google App Engine
This is Rietveld 408576698