Introduce the "Embedded" category.

Introduce the "Embedded" category.

It is not visible from the dart2js command line.

BUG=
R=brianwilkerson@google.com, johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/0aef0efb6a38a65fa676fa9e8daa85a972521745
Reverted: https://codereview.chromium.org/1401513002

Committed: https://github.com/dart-lang/sdk/commit/a763c71d92e2e1f3e36c702e2b1b3249f774ff9a

[sigurdm, 2015-10-08 12:11:28]

Patchset #1 (id:1) has been deleted

[sigurdm, 2015-10-08 12:15:22]

Patchset #1 (id:20001) has been deleted

[sigurdm, 2015-10-08 12:17:10]

sigurdm@google.com changed reviewers:
+ johnniwinther@google.com

[sigurdm, 2015-10-08 12:17:10]

@johnniwinther: Do you know who would be the right one to review the analyzer
changes?

[Johnni Winther, 2015-10-08 13:14:48]

On 2015/10/08 12:17:10, sigurdm wrote:
> @johnniwinther: Do you know who would be the right one to review the analyzer
> changes?

Add paulberry@.

[Johnni Winther, 2015-10-08 13:14:56]

lgtm

https://codereview.chromium.org/1395863002/diff/40001/sdk/lib/_internal/sdk_l...
File sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart (right):

https://codereview.chromium.org/1395863002/diff/40001/sdk/lib/_internal/sdk_l...
sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart:332: if (_categories
== "") return <Category>[];
const <Category>[]

[sigurdm, 2015-10-08 13:29:00]

sigurdm@google.com changed reviewers:
+ paulberry@google.com

[sigurdm, 2015-10-08 13:29:01]

@paulberry: We are generalizing the concept of categories. Could you look at the
changes to the analyzer?

Looking forward we probably want the analyzer to understand the same categories
as dart2js.

https://codereview.chromium.org/1395863002/diff/40001/sdk/lib/_internal/sdk_l...
File sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart (right):

https://codereview.chromium.org/1395863002/diff/40001/sdk/lib/_internal/sdk_l...
sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart:332: if (_categories
== "") return <Category>[];
On 2015/10/08 13:14:55, Johnni Winther wrote:
> const <Category>[]

Done.

[Brian Wilkerson, 2015-10-08 17:03:17]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-10-08 17:03:17]

LGTM

https://codereview.chromium.org/1395863002/diff/60001/sdk/lib/_internal/sdk_l...
File sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart (right):

https://codereview.chromium.org/1395863002/diff/60001/sdk/lib/_internal/sdk_l...
sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart:48: categories:
"Clientd",
"Clientd" --> "Client"

[sigurdm, 2015-10-09 09:14:26]

https://codereview.chromium.org/1395863002/diff/60001/sdk/lib/_internal/sdk_l...
File sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart (right):

https://codereview.chromium.org/1395863002/diff/60001/sdk/lib/_internal/sdk_l...
sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart:48: categories:
"Clientd",
On 2015/10/08 17:03:17, Brian Wilkerson wrote:
> "Clientd" --> "Client"

Thanks!

Actually this entry could probably be removed, because the VM no longer relies
on this metadata file.

[sigurdm, 2015-10-09 11:08:44]

Committed patchset #3 (id:80001) manually as
0aef0efb6a38a65fa676fa9e8daa85a972521745 (presubmit successful).

[sigurdm, 2015-10-09 11:43:45]

Patchset #4 (id:100001) has been deleted

[sigurdm, 2015-10-09 11:45:41]

PTAL

[Johnni Winther, 2015-10-09 11:48:00]

lgtm

[Brian Wilkerson, 2015-10-09 13:51:19]

LGTM

[sigurdm, 2015-10-12 10:16:00]

Committed patchset #4 (id:120001) manually as
a763c71d92e2e1f3e36c702e2b1b3249f774ff9a (presubmit successful).