Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1401513002: Revert "Introduce the "Embedded" category." (Closed)

Created:
5 years, 2 months ago by sigurdm
Modified:
5 years, 2 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Introduce the "Embedded" category." This reverts commit 0aef0efb6a38a65fa676fa9e8daa85a972521745. BUG= Committed: https://github.com/dart-lang/sdk/commit/01d69770307686c5b349e4ddc45ba41125c41fab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -282 lines) Patch
M pkg/analyzer/lib/src/generated/sdk.dart View 3 chunks +3 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/apiimpl.dart View 6 chunks +54 lines, -71 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +2 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 2 chunks +12 lines, -3 lines 0 comments Download
M pkg/compiler/samples/darttags/darttags.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/samples/jsonify/jsonify.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart View 5 chunks +40 lines, -84 lines 0 comments Download
M tests/compiler/dart2js/analyze_api_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_helper.dart View 3 chunks +1 line, -3 lines 0 comments Download
D tests/compiler/dart2js/categories_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/compiler/dart2js/embedded_category_api_boundary_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
M tests/compiler/dart2js/library_resolution_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sigurdm
TBR
5 years, 2 months ago (2015-10-09 11:29:29 UTC) #2
sigurdm
Committed patchset #1 (id:1) manually as 01d69770307686c5b349e4ddc45ba41125c41fab (presubmit successful).
5 years, 2 months ago (2015-10-09 11:30:01 UTC) #3
Johnni Winther
5 years, 2 months ago (2015-10-09 11:47:02 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698