FYI: add strong mode checking to error verifier's task

pkg/analyzer/test/src/task/strong/strong_test_helper.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(jmesserly): this file needs to be refactored, it's a port from
 // package:dev_compiler's tests
 library test.src.task.strong.strong_test_helper;
 
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/src/context/context.dart' show SdkAnalysisContext;
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/engine.dart' hide SdkAnalysisContext;
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/task/strong/checker.dart';
 import 'package:analyzer/src/task/strong/rules.dart';
 import 'package:logging/logging.dart'; // TODO(jmesserly): remove
 import 'package:source_span/source_span.dart'; // TODO(jmesserly): remove
 import 'package:unittest/unittest.dart';
 
-
 /// Run the checker on a program with files contents as indicated in
 /// [testFiles].
 ///
 /// This function makes several assumptions to make it easier to describe error
 /// expectations:
 ///
 ///   * a file named `/main.dart` exists in [testFiles].
 ///   * all expected failures are listed in the source code using comments
 ///   immediately in front of the AST node that should contain the error.
 ///   * errors are formatted as a token `level:Type`, where `level` is the
@@ skipping 34 matching lines @@
       new MockDartSdk(mockSdkSources, reportMissing: true).resolver,
       uriResolver
     ]);
 
     // Run the checker on /main.dart.
     Source mainSource = uriResolver.resolveAbsolute(new Uri.file('/main.dart'));
     var initialLibrary =
         context.resolveCompilationUnit2(mainSource, mainSource);
 
     var collector = new _ErrorCollector();
-    var errorReporter = new ErrorReporter(collector, mainSource);
-    var checker = new CodeChecker(new TypeRules(context.typeProvider),
-        errorReporter);
+    var checker =
+        new CodeChecker(new TypeRules(context.typeProvider), collector);
 
     // Extract expectations from the comments in the test files, and
     // check that all errors we emit are included in the expected map.
     var allLibraries = reachableLibraries(initialLibrary.element.library);
     for (var lib in allLibraries) {
       for (var unit in lib.units) {
         var errors = <AnalysisError>[];
         collector.errors = errors;
 
         var source = unit.source;
         if (source.uri.scheme == 'dart') continue;
-        errorReporter.source = unit.source;
 
         var librarySource = context.getLibrariesContaining(source).single;
         var resolved = context.resolveCompilationUnit2(source, librarySource);
         checker.visitCompilationUnit(resolved);
 
         new _ExpectedErrorVisitor(errors).validate(resolved);
       }
     }
   });
 }
@@ skipping 175 matching lines @@
     expect(tokens[2], "be", reason: 'invalid error descriptor');
     if (tokens[0] == "pass") return null;
     // TODO(leafp) For now, we just use whatever the current expectation is,
     // eventually we could do more automated reporting here.
     return _parse(tokens[0]);
   }
 
   String toString() => '$level $typeName';
 }
 
-
 /// Dart SDK which contains a mock implementation of the SDK libraries. May be
 /// used to speed up execution when most of the core libraries is not needed.
 class MockDartSdk implements DartSdk {
   final Map<Uri, _MockSdkSource> _sources = {};
   final bool reportMissing;
   final Map<String, SdkLibrary> _libs = {};
   final String sdkVersion = '0';
   List<String> get uris => _sources.keys.map((uri) => '$uri').toList();
   final AnalysisContext context = new SdkAnalysisContext();
   DartUriResolver _resolver;
@@ skipping 149 matching lines @@
   'dart:math': '''
         library dart.math;
         class Random {
           bool nextBool() {}
         }
         num min(num x, num y) {}
         num max(num x, num y) {}
         ''',
 };
 
-
 /// Returns all libraries transitively imported or exported from [start].
 List<LibraryElement> reachableLibraries(LibraryElement start) {
   var results = <LibraryElement>[];
   var seen = new Set();
   void find(LibraryElement lib) {
     if (seen.contains(lib)) return;
     seen.add(lib);
     results.add(lib);
     lib.importedLibraries.forEach(find);
     lib.exportedLibraries.forEach(find);
@@ skipping 25 matching lines @@
   if (levelName == 'warning') return _MAGENTA_COLOR;
   if (levelName == 'info') return _CYAN_COLOR;
   return null;
 }
 
 const String _RED_COLOR = '\u001b[31m';
 const String _MAGENTA_COLOR = '\u001b[35m';
 const String _CYAN_COLOR = '\u001b[36m';
 const String GREEN_COLOR = '\u001b[32m';
 const String NO_COLOR = '\u001b[0m';