Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Unified Diff: runtime/vm/timeline_test.cc

Issue 1395803002: Stop holding onto TimelineEvents (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/timeline.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline_test.cc
diff --git a/runtime/vm/timeline_test.cc b/runtime/vm/timeline_test.cc
index bdd2fddf7e4e988a71f93703fd418e137622a159..17fea5d44e753f06b8bc12f966f5b187e11b1dff 100644
--- a/runtime/vm/timeline_test.cc
+++ b/runtime/vm/timeline_test.cc
@@ -37,7 +37,7 @@ class TimelineTestHelper : public AllStatic {
event->StreamInit(stream);
}
- static TimelineEvent* FakeThreadEvent(
+ static void FakeThreadEvent(
TimelineEventBlock* block,
intptr_t ftid,
const char* label = "fake",
@@ -49,7 +49,6 @@ class TimelineTestHelper : public AllStatic {
if (stream != NULL) {
event->StreamInit(stream);
}
- return event;
}
static void FakeDuration(
@@ -63,6 +62,7 @@ class TimelineTestHelper : public AllStatic {
TimelineEvent* event = recorder->StartEvent();
ASSERT(event != NULL);
event->Duration(label, start, end);
+ event->Complete();
}
static void FakeBegin(
@@ -75,6 +75,7 @@ class TimelineTestHelper : public AllStatic {
TimelineEvent* event = recorder->StartEvent();
ASSERT(event != NULL);
event->Begin(label, start);
+ event->Complete();
}
static void FakeEnd(
@@ -87,6 +88,7 @@ class TimelineTestHelper : public AllStatic {
TimelineEvent* event = recorder->StartEvent();
ASSERT(event != NULL);
event->End(label, end);
+ event->Complete();
}
static void Clear(TimelineEventEndlessRecorder* recorder) {
« no previous file with comments | « runtime/vm/timeline.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698