Stop holding onto TimelineEvents

runtime/vm/timeline_test.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <cstring>
 
 #include "platform/assert.h"
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
@@ skipping 19 matching lines @@
   TimelineEventRecorder* recorder_;
 };
 
 
 class TimelineTestHelper : public AllStatic {
  public:
   static void SetStream(TimelineEvent* event, TimelineStream* stream) {
     event->StreamInit(stream);
   }
 
-  static TimelineEvent* FakeThreadEvent(
+  static void FakeThreadEvent(
       TimelineEventBlock* block,
       intptr_t ftid,
       const char* label = "fake",
       TimelineStream* stream = NULL) {
     TimelineEvent* event = block->StartEvent();
     ASSERT(event != NULL);
     event->DurationBegin(label);
     event->thread_ = OSThread::ThreadIdFromIntPtr(ftid);
     if (stream != NULL) {
       event->StreamInit(stream);
     }
-    return event;
   }
 
   static void FakeDuration(
       TimelineEventRecorder* recorder,
       const char* label,
       int64_t start,
       int64_t end) {
     ASSERT(recorder != NULL);
     ASSERT(start < end);
     ASSERT(label != NULL);
     TimelineEvent* event = recorder->StartEvent();
     ASSERT(event != NULL);
     event->Duration(label, start, end);
+    event->Complete();
   }
 
   static void FakeBegin(
       TimelineEventRecorder* recorder,
       const char* label,
       int64_t start) {
     ASSERT(recorder != NULL);
     ASSERT(label != NULL);
     ASSERT(start >= 0);
     TimelineEvent* event = recorder->StartEvent();
     ASSERT(event != NULL);
     event->Begin(label, start);
+    event->Complete();
   }
 
   static void FakeEnd(
       TimelineEventRecorder* recorder,
       const char* label,
       int64_t end) {
     ASSERT(recorder != NULL);
     ASSERT(label != NULL);
     ASSERT(end >= 0);
     TimelineEvent* event = recorder->StartEvent();
     ASSERT(event != NULL);
     event->End(label, end);
+    event->Complete();
   }
 
   static void Clear(TimelineEventEndlessRecorder* recorder) {
     ASSERT(recorder != NULL);
     recorder->Clear();
   }
 
   static void FinishBlock(TimelineEventBlock* block) {
     block->Finish();
   }
@@ skipping 735 matching lines @@
   {
     TimelinePauses pauses(zone, isolate, recorder);
     pauses.Setup();
     pauses.CalculatePauseTimesForThread(tid);
     EXPECT(pauses.has_error());
   }
   TimelineTestHelper::Clear(recorder);
 }
 
 }  // namespace dart