Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 13958002: Revert 192940 "Delete CopyRecursiveDirNoCache from test_file_util." (Closed)

Created:
7 years, 8 months ago by tonyg
Modified:
7 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 192940 "Delete CopyRecursiveDirNoCache from test_file_util." Likely culprit for startup test crashes on mac. BUG=229665 > Delete CopyRecursiveDirNoCache from test_file_util. > > This function was used in only one place and that place was wrong. > > The implementation was long and complicated on Windows, and long and > complicated and copied verbatim from elsewhere with 3 lines different on Posix. > > The place it was used was in the proxy launcher when copying the profile. It's > not clear to me why we wouldn't want the profile files in the filesystem cache > when running tests. Quite the opposite, we want the tests to run as fast as > possible. > > The only place this should matter is in the startup tests. And the startup > tests do things to the profile after it gets copied that should page some files > back in! This adds another step to the startup tests to evict the profile files > for cold startup tests only. > > This is a reland of r191854 which broke the startup test. The previous patch replaced the CopyRecursive call with CopyDirectory which does something slightly different. This new patch implements a CopyDirectoryContents function to do what's required here. > > patch from issue 13394003 > > Review URL: https://codereview.chromium.org/13646016 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -30 lines) Patch
M trunk/src/base/test/test_file_util.h View 1 chunk +9 lines, -0 lines 0 comments Download
M trunk/src/base/test/test_file_util_posix.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M trunk/src/base/test/test_file_util_win.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M trunk/src/chrome/test/automation/proxy_launcher.cc View 2 chunks +2 lines, -24 lines 0 comments Download
M trunk/src/chrome/test/perf/startup_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tonyg
7 years, 8 months ago (2013-04-09 23:05:36 UTC) #1
tonyg
7 years, 8 months ago (2013-04-09 23:05:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r193253.

Powered by Google App Engine
This is Rietveld 408576698