Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 13646016: Delete CopyRecursiveDirNoCache from test_file_util. (Closed)

Created:
7 years, 8 months ago by brettw
Modified:
7 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, chrome-speed-team+watch_google.com, robertshield, erikwright+watch_chromium.org, kkania, sail+watch_chromium.org
Visibility:
Public.

Description

Delete CopyRecursiveDirNoCache from test_file_util. This function was used in only one place and that place was wrong. The implementation was long and complicated on Windows, and long and complicated and copied verbatim from elsewhere with 3 lines different on Posix. The place it was used was in the proxy launcher when copying the profile. It's not clear to me why we wouldn't want the profile files in the filesystem cache when running tests. Quite the opposite, we want the tests to run as fast as possible. The only place this should matter is in the startup tests. And the startup tests do things to the profile after it gets copied that should page some files back in! This adds another step to the startup tests to evict the profile files for cold startup tests only. This is a reland of r191854 which broke the startup test. The previous patch replaced the CopyRecursive call with CopyDirectory which does something slightly different. This new patch implements a CopyDirectoryContents function to do what's required here. patch from issue 13394003 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192940

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -140 lines) Patch
M base/test/test_file_util.h View 1 chunk +0 lines, -9 lines 0 comments Download
M base/test/test_file_util_posix.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M base/test/test_file_util_win.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 1 2 chunks +24 lines, -2 lines 0 comments Download
M chrome/test/perf/startup_test.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
Patchset 1 is the same as the previousl one in https://codereview.chromium.org/13394003/ Patchset 2 is the ...
7 years, 8 months ago (2013-04-05 23:36:58 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm, Check if you are actually trying startup_test which is what caused the rollback.
7 years, 8 months ago (2013-04-08 17:47:00 UTC) #2
brettw
Committed patchset #2 manually as r192940 (presubmit successful).
7 years, 8 months ago (2013-04-08 23:00:58 UTC) #3
kojih
7 years, 8 months ago (2013-04-10 08:55:12 UTC) #4
Message was sent while issue was closed.
Hi brettw,
please see:
https://code.google.com/p/chromium/issues/detail?id=226099

Powered by Google App Engine
This is Rietveld 408576698