bluetooth: android: BluetoothRemoteGattServiceAndroid::GetUUID

bluetooth: android: BluetoothRemoteGattServiceAndroid::GetUUID

Create a Java class ChromeBluetoothRemoteGattService to
implement BluetoothRemoteGattServiceAndroid, and implement
GetUUID.

Correct mistaken implementation of instanceID. Android's
getInstanceId is only unique for services with the same
UUID, so a device unique instance ID must join the UUID and
Android's getInstanceId.

Add the ability for tests to create services by providing a
vector of UUID strings.

BUG=541400
Committed: https://crrev.com/33aa3f45ab74c7d832cc9f717be85abb7bb53011
Cr-Commit-Position: refs/heads/master@{#354420}

[scheib, 2015-10-15 19:05:21]

Patchset #2 (id:20001) has been deleted

[Jeffrey Yasskin, 2015-10-15 23:48:29]

jyasskin@chromium.org changed reviewers:
+ jyasskin@chromium.org

[Jeffrey Yasskin, 2015-10-15 23:48:30]

It's so boilerplate, I'm sure I missed something. LGTM.

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/androi...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java
(right):

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/androi...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java:166:
// Create a device unique service ID, getInstanceId only differs
nit: s/,/./ or s/,/;/

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_unittest.cc (left):

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_unittest.cc:440: // their properties.
http://crbug.com/541400
If you're fixing this, put it in the patch's BUG= list.

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_gatt_service_unittest.cc (right):

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_gatt_service_unittest.cc:34: EXPECT_EQ(uuid,
device->GetGattServices()[0]->GetUUID());
Also assert their instance IDs are distinct?

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/test/a...
File
device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java
(right):

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/test/a...
device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java:321:
public UUID getUuid() {
Nit: Put the accessors in the same order as the fields.

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_android.cc (right):

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_android.cc:115: std::vector<std::string>
uuids) {
Pass by const&.

[scheib, 2015-10-16 00:23:16]

Patchset #3 (id:60001) has been deleted

[scheib, 2015-10-16 00:23:36]

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/androi...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java
(right):

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/androi...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java:166:
// Create a device unique service ID, getInstanceId only differs
On 2015/10/15 23:48:30, jyasskin-OOO until Oct 30 wrote:
> nit: s/,/./ or s/,/;/

Done.

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_unittest.cc (left):

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_unittest.cc:440: // their properties.
http://crbug.com/541400
On 2015/10/15 23:48:30, jyasskin-OOO until Oct 30 wrote:
> If you're fixing this, put it in the patch's BUG= list.

Done.

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_gatt_service_unittest.cc (right):

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_gatt_service_unittest.cc:34: EXPECT_EQ(uuid,
device->GetGattServices()[0]->GetUUID());
On 2015/10/15 23:48:30, jyasskin-OOO until Oct 30 wrote:
> Also assert their instance IDs are distinct?

Done.

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/test/a...
File
device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java
(right):

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/test/a...
device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java:321:
public UUID getUuid() {
On 2015/10/15 23:48:30, jyasskin-OOO until Oct 30 wrote:
> Nit: Put the accessors in the same order as the fields.

Done. - but fixing fields. The method order here matches the Android SDK.

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/test/b...
File device/bluetooth/test/bluetooth_test_android.cc (right):

https://codereview.chromium.org/1395783005/diff/40001/device/bluetooth/test/b...
device/bluetooth/test/bluetooth_test_android.cc:115: std::vector<std::string>
uuids) {
On 2015/10/15 23:48:30, jyasskin-OOO until Oct 30 wrote:
> Pass by const&.

Done.

[scheib, 2015-10-16 00:23:47]

The CQ bit was checked by scheib@chromium.org

[scheib, 2015-10-16 00:23:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/1395783005/#ps80001
(title: "addressed jyasskin comments")

[commit-bot: I haz the power, 2015-10-16 00:24:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395783005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395783005/80001

[commit-bot: I haz the power, 2015-10-16 01:23:22]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-10-16 01:23:58]

Patchset 3 (id:??) landed as
https://crrev.com/33aa3f45ab74c7d832cc9f717be85abb7bb53011
Cr-Commit-Position: refs/heads/master@{#354420}