device/bluetooth/test/bluetooth_test.h - Issue 1395783005: bluetooth: android: BluetoothRemoteGattServiceAndroid::GetUUID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/test/bluetooth_test.h

Issue 1395783005: bluetooth: android: BluetoothRemoteGattServiceAndroid::GetUUID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed jyasskin comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java ('k') | device/bluetooth/test/bluetooth_test_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/test/bluetooth_test.h

diff --git a/device/bluetooth/test/bluetooth_test.h b/device/bluetooth/test/bluetooth_test.h

index 43b47f2f10a45d2e787e6b0e583a64f17fecbd20..11e6b6b05162ec4ccbb2667ce7039acc7b54e7a5 100644

--- a/device/bluetooth/test/bluetooth_test.h

+++ b/device/bluetooth/test/bluetooth_test.h

@@ -84,10 +84,12 @@ class BluetoothTestBase : public testing::Test {

// Simulates GattConnection disconnecting.

virtual void SimulateGattDisconnection(BluetoothDevice* device) {}

- // Simulates success of discovering services. Two services are created.

- // TODO(scheib): Add more control over how many services are created and

- // their properties. http://crbug.com/541400

- virtual void SimulateGattServicesDiscovered(BluetoothDevice* device) {}

+ // Simulates success of discovering services. |uuids| is used to create a

+ // service for each UUID string. Multiple UUIDs with the same value produce

+ // multiple service instances.

+ virtual void SimulateGattServicesDiscovered(

+ BluetoothDevice* device,

+ const std::vector<std::string>& uuids) {}

// Simulates failure to discover services.

virtual void SimulateGattServicesDiscoveryError(BluetoothDevice* device) {}