Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1395713002: Merge to XFA: Rename IFXJS_Runtime and IFXJS_Context to IJS_. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Rename IFXJS_Runtime and IFXJS_Context to IJS_. Merge conflicts in: fpdfsdk/src/javascript/Document.cpp fpdfsdk/src/javascript/JS_Define.h New code in: fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (cherry picked from commit 213a172779fddbd7e588ee2e2b3906ccc47d6896) Original Review URL: https://codereview.chromium.org/1386173002 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ba038bc14bfeb4d011d57f388871f7f14c4c3c22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+600 lines, -674 lines) Patch
M fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 3 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 4 chunks +14 lines, -10 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/Document.h View 2 chunks +72 lines, -88 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 61 chunks +73 lines, -73 lines 0 comments Download
M fpdfsdk/src/javascript/Field.h View 2 chunks +79 lines, -115 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 64 chunks +79 lines, -81 lines 0 comments Download
M fpdfsdk/src/javascript/Icon.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Icon.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Define.h View 9 chunks +25 lines, -25 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.h View 1 chunk +22 lines, -22 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 22 chunks +23 lines, -23 lines 0 comments Download
M fpdfsdk/src/javascript/app.h View 1 chunk +33 lines, -39 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 26 chunks +35 lines, -37 lines 0 comments Download
M fpdfsdk/src/javascript/color.h View 1 chunk +14 lines, -14 lines 0 comments Download
M fpdfsdk/src/javascript/color.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/console.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/console.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/event.h View 1 chunk +20 lines, -32 lines 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 20 chunks +20 lines, -22 lines 0 comments Download
M fpdfsdk/src/javascript/global.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/report.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/report.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/util.h View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Lei, for review.
5 years, 2 months ago (2015-10-07 20:22:35 UTC) #1
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-07 20:43:27 UTC) #2
Tom Sepez
5 years, 2 months ago (2015-10-08 19:03:04 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ba038bc14bfeb4d011d57f388871f7f14c4c3c22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698