Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1386173002: Rename IFXJS_Runtime and IFXJS_Context to IJS_. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename IFXJS_Runtime and IFXJS_Context to IJS_. Nothing but sed. FXJS is a layer that makes it easier to define objects in V8, but has no knowledge of PDF-specific native objects. It could in theory be used to implement other sets of native objects. JS is the layer that implements PDF-specific native objects on top of FXJS. Therefore, the classes used to interface to JS should be named using IJS_. IFXJS_ is reserved for someday adding better API for FXJS iteslf. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/213a172779fddbd7e588ee2e2b3906ccc47d6896

Patch Set 1 #

Patch Set 2 : Comment in fxjs_v8.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+599 lines, -675 lines) Patch
M fpdfsdk/include/fsdk_mgr.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 2 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 4 chunks +14 lines, -10 lines 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/Document.h View 2 chunks +72 lines, -88 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 61 chunks +73 lines, -73 lines 0 comments Download
M fpdfsdk/src/javascript/Field.h View 2 chunks +79 lines, -115 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 64 chunks +79 lines, -81 lines 0 comments Download
M fpdfsdk/src/javascript/Icon.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Icon.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Define.h View 9 chunks +29 lines, -31 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.h View 1 chunk +22 lines, -22 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 22 chunks +23 lines, -23 lines 0 comments Download
M fpdfsdk/src/javascript/app.h View 1 chunk +33 lines, -39 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 26 chunks +35 lines, -37 lines 0 comments Download
M fpdfsdk/src/javascript/color.h View 1 chunk +14 lines, -14 lines 0 comments Download
M fpdfsdk/src/javascript/color.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/console.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/console.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/event.h View 1 chunk +20 lines, -32 lines 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 20 chunks +20 lines, -22 lines 0 comments Download
M fpdfsdk/src/javascript/global.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/report.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/report.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/util.h View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Tom Sepez
Lei, this has been bugging me for a really long time now.
5 years, 2 months ago (2015-10-06 18:58:04 UTC) #1
Tom Sepez
Note to self: Issues to which a reviewer has actually been specified are more likely ...
5 years, 2 months ago (2015-10-07 17:15:11 UTC) #3
Lei Zhang
lgtm typo in commit msg: implementes
5 years, 2 months ago (2015-10-07 18:18:55 UTC) #4
Tom Sepez
On 2015/10/07 18:18:55, Lei Zhang wrote: > lgtm > > typo in commit msg: implementes ...
5 years, 2 months ago (2015-10-07 19:36:18 UTC) #5
Tom Sepez
On 2015/10/07 18:18:55, Lei Zhang wrote: > lgtm > > typo in commit msg: implementes ...
5 years, 2 months ago (2015-10-07 19:36:25 UTC) #6
Tom Sepez
New comment in fxjs_v8.h
5 years, 2 months ago (2015-10-07 19:43:02 UTC) #7
Tom Sepez
5 years, 2 months ago (2015-10-07 19:52:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
213a172779fddbd7e588ee2e2b3906ccc47d6896 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698