Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 13957008: Merge 193302 "Force GPU switch with CGLSetVirtualScreen only for..." (Closed)

Created:
7 years, 8 months ago by kareng
Modified:
7 years, 8 months ago
CC:
chromium-reviews, apatrick_chromium, anantha
Visibility:
Public.

Description

Merge 193302 "Force GPU switch with CGLSetVirtualScreen only for..." > Force GPU switch with CGLSetVirtualScreen only for compositor > > Only compositor contexts are known to use only the subset of GL > that can be safely migrated between the iGPU and the dGPU. Mark > those contexts as safe to forcibly transition between the GPUs. > > In particular, Intel GPUs support using a GL_STENCIL_INDEX8 > attachment with no depth buffer, but NV GPUs don't. Skia will use > this FBO combo if it is listed as available. > > If we use this combo on the iGPU and then forcibly transition the > GL context using this combo from the iGPU to the dGPU, corruption > occurs on NV, and a hang happens on AMD. > > Further, if we cache complete FBO combos, then we will cache this > combo as valid when using the iGPU, and claim that it's valid when > using the dGPU, resulting in GL errors. > > BUG=180876 > > Review URL: https://chromiumcodereview.appspot.com/13746002 TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -41 lines) Patch
M gpu/command_buffer/service/framebuffer_manager.h View 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 2 chunks +33 lines, -16 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 6 chunks +30 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/gl/gl_context.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_context.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_context_cgl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gl/gl_context_cgl.cc View 3 chunks +36 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kareng
7 years, 8 months ago (2013-04-16 19:25:21 UTC) #1
kareng
Committed patchset #1 manually as r194413.
7 years, 8 months ago (2013-04-16 19:25:41 UTC) #2
Ken Russell (switch to Gerrit)
Anantha and QA team: please see https://code.google.com/p/chromium/issues/detail?id=180876#c96 for the testing scenarios for this merge.
7 years, 8 months ago (2013-04-16 20:24:48 UTC) #3
ananthak
7 years, 8 months ago (2013-04-17 00:23:09 UTC) #4
Thanks for the detailed instructions. Team will verify them once the build
is available.


On Tue, Apr 16, 2013 at 1:24 PM, <kbr@chromium.org> wrote:

> Anantha and QA team: please see
>
https://code.google.com/p/**chromium/issues/detail?id=**180876#c96<https://co...
the testing
> scenarios for this merge.
>
>
>
https://codereview.chromium.**org/13957008/<https://codereview.chromium.org/1...
>

Powered by Google App Engine
This is Rietveld 408576698