Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 139563002: [OTS] Add support for the MATH table. (Closed)

Created:
5 years, 6 months ago by fred.wang
Modified:
5 years, 5 months ago
Reviewers:
Kunihiko Sakamoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/external/ots.git@master
Visibility:
Public.

Description

[OTS] Add support for the MATH table. BUG=334318 R=ksakamoto@chromium.org

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address review comments. #

Patch Set 3 : Add <limits> header. #

Total comments: 2

Patch Set 4 : More fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+645 lines, -6 lines) Patch
M ots-common.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/layout.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/layout.cc View 5 chunks +19 lines, -5 lines 0 comments Download
A src/math.cc View 1 2 3 1 chunk +594 lines, -0 lines 0 comments Download
A src/math_.h View 1 chunk +25 lines, -0 lines 0 comments Download
M src/ots.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ots.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
fred.wang
5 years, 6 months ago (2014-01-15 16:09:00 UTC) #1
fred.wang
I'll send a copy of the Microsoft document to Kunihiko Sakamoto by mail. Anyone willing ...
5 years, 6 months ago (2014-01-15 16:12:10 UTC) #2
Kunihiko Sakamoto
In general, looks good. I only have some minor comments. Also, please address the "Line ...
5 years, 6 months ago (2014-01-17 10:51:36 UTC) #3
fred.wang
Thank you for the review. I've uploaded a new version.
5 years, 6 months ago (2014-01-17 11:28:30 UTC) #4
Kunihiko Sakamoto
https://codereview.chromium.org/139563002/diff/140001/src/math.cc File src/math.cc (right): https://codereview.chromium.org/139563002/diff/140001/src/math.cc#newcode311 src/math.cc:311: data + offset_math_italics_correction_info, Oh, my comment wasn't very clear. ...
5 years, 6 months ago (2014-01-17 13:01:55 UTC) #5
Kunihiko Sakamoto
lgtm
5 years, 5 months ago (2014-01-20 02:07:56 UTC) #6
Kunihiko Sakamoto
5 years, 5 months ago (2014-01-20 02:16:41 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698