[OTS] Add support for the MATH table.

[OTS] Add support for the MATH table.

BUG=334318
R=ksakamoto@chromium.org

[fred.wang, 2014-01-15 16:12:10]

I'll send a copy of the Microsoft document to Kunihiko Sakamoto by mail. Anyone
willing to review the patch can just ask me to a copy.

[Kunihiko Sakamoto, 2014-01-17 10:51:36]

In general, looks good.
I only have some minor comments.

Also, please address the "Line ends in whitespace" lint errors in math.cc.
https://codereview.chromium.org/lint_patch/issue139563002_1_10004

Thanks!

https://codereview.chromium.org/139563002/diff/1/ots-common.gypi
File ots-common.gypi (right):

https://codereview.chromium.org/139563002/diff/1/ots-common.gypi#newcode49
ots-common.gypi:49: 'src/math.h',
math_.h

https://codereview.chromium.org/139563002/diff/1/src/math.cc
File src/math.cc (right):

https://codereview.chromium.org/139563002/diff/1/src/math.cc#newcode267
src/math.cc:267: // Check TopRigh, TopLeft, BottomRight and BottomLeft Math
Kern.
TopRigh -> TopRight

https://codereview.chromium.org/139563002/diff/1/src/math.cc#newcode309
src/math.cc:309: !ParseMathItalicsCorrectionInfoTable(data +
offset_math_italics_correction_info,
Please keep <=80 characters per line.
Break after '(' and indent +4 chars.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

https://codereview.chromium.org/139563002/diff/1/src/math.cc#newcode348
src/math.cc:348: size_t length, const uint16_t num_glyphs) {
Please fix indent.

https://codereview.chromium.org/139563002/diff/1/src/math.cc#newcode373
src/math.cc:373: if (glyph > num_glyphs) {
should be >=

https://codereview.chromium.org/139563002/diff/1/src/math.cc#newcode423
src/math.cc:423: if (glyph > num_glyphs) {
should be >=

https://codereview.chromium.org/139563002/diff/1/src/math.cc#newcode476
src/math.cc:476: if (!subtable.Skip(2) || // MinConnectorOverlap
Two spaces between code and comment

https://codereview.chromium.org/139563002/diff/1/src/math.cc#newcode549
src/math.cc:549: return OTS_FAILURE();
This makes the entire font fail.
Maybe drop the table and return true?

[fred.wang, 2014-01-17 11:28:30]

Thank you for the review. I've uploaded a new version.

[Kunihiko Sakamoto, 2014-01-17 13:01:55]

https://codereview.chromium.org/139563002/diff/140001/src/math.cc
File src/math.cc (right):

https://codereview.chromium.org/139563002/diff/140001/src/math.cc#newcode311
src/math.cc:311: data + offset_math_italics_correction_info,
Oh, my comment wasn't very clear. I meant 4 spaces indent relative to the
previous line.

https://codereview.chromium.org/139563002/diff/140001/src/math.cc#newcode550
src/math.cc:550: DROP_THIS_TABLE;
Can you add

 OTS_WARNING("bad offset in MATH header");

before this line?

[Kunihiko Sakamoto, 2014-01-20 02:07:56]

lgtm

[Kunihiko Sakamoto, 2014-01-20 02:16:41]

Landed.
https://code.google.com/p/ots/source/detail?r=110