Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: core/src/fxcodec/jbig2/JBig2_List.h

Issue 1395613003: Put CJBig2_SymbolDict's images in a CJBig2_List container. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/src/fxcodec/jbig2/JBig2_List.h
diff --git a/core/src/fxcodec/jbig2/JBig2_List.h b/core/src/fxcodec/jbig2/JBig2_List.h
index e033eb23ea4d7b4a9d5ba674f382799f95bf3c75..57cc0b0d96b75104a049f3944c0578bcc559ea2c 100644
--- a/core/src/fxcodec/jbig2/JBig2_List.h
+++ b/core/src/fxcodec/jbig2/JBig2_List.h
@@ -4,8 +4,8 @@
// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
-#ifndef _JBIG2_LIST_H_
-#define _JBIG2_LIST_H_
+#ifndef CORE_SRC_FXCODEC_JBIG2_JBIG2_LIST_H_
Tom Sepez 2015/10/07 19:20:01 nit: maybe add a comment here that this is a vecto
Lei Zhang 2015/10/08 04:52:04 Done.
+#define CORE_SRC_FXCODEC_JBIG2_JBIG2_LIST_H_
#include <vector>
@@ -29,7 +29,7 @@ class CJBig2_List {
size_t size() const { return m_vector.size(); }
void resize(size_t count) { m_vector.resize(count); }
- TYPE* get(size_t index) { return m_vector[index]; }
+ TYPE* get(size_t index) const { return m_vector[index]; }
Tom Sepez 2015/10/07 19:20:01 need a set method here so we can do more that just
Lei Zhang 2015/10/08 04:52:04 Maybe later when needed? Or do you prefer I use it
TYPE* back() { return m_vector.back(); }
@@ -37,4 +37,4 @@ class CJBig2_List {
std::vector<TYPE*> m_vector;
};
-#endif
+#endif // CORE_SRC_FXCODEC_JBIG2_JBIG2_LIST_H_

Powered by Google App Engine
This is Rietveld 408576698