Put CJBig2_SymbolDict's images in a CJBig2_List container.

core/src/fxcodec/jbig2/JBig2_List.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
-#ifndef _JBIG2_LIST_H_
-#define _JBIG2_LIST_H_
+#ifndef CORE_SRC_FXCODEC_JBIG2_JBIG2_LIST_H_

[Tom Sepez, 2015/10/07 19:20:01]

nit: maybe add a comment here that this is a vector of pointers that owns (and
deletes) all its elements.

[Lei Zhang, 2015/10/08 04:52:04]

Done.

+#define CORE_SRC_FXCODEC_JBIG2_JBIG2_LIST_H_
 
 #include <vector>
 
 template <class TYPE>
 class CJBig2_List {
  public:
   CJBig2_List() {}
 
   ~CJBig2_List() {
     clear();
   }
 
   void clear() {

[Tom Sepez, 2015/10/07 19:20:01]

nit: Codesearch says this is called only from dtor; please confirm and move into
dtor itself.

[Lei Zhang, 2015/10/08 04:52:04]

clear() corresponds to vector::clear(). We may find a use for it later.

     for (size_t i = 0; i < m_vector.size(); ++i)
       delete m_vector[i];
     m_vector.clear();

[Tom Sepez, 2015/10/07 19:20:01]

nit: at which point the .clear() becomes pointless in dtor.

[Lei Zhang, 2015/10/08 04:52:04]

But it's ok as is.

   }
 
   void push_back(TYPE* pItem) { m_vector.push_back(pItem); }
 
   size_t size() const { return m_vector.size(); }
   void resize(size_t count) { m_vector.resize(count); }
 
-  TYPE* get(size_t index) { return m_vector[index]; }
+  TYPE* get(size_t index) const { return m_vector[index]; }
 

[Tom Sepez, 2015/10/07 19:20:01]

need a set method here so we can do more that just push onto the back?

[Lei Zhang, 2015/10/08 04:52:04]

Maybe later when needed? Or do you prefer I use it in this CL?

   TYPE* back() { return m_vector.back(); }
 
  private:
   std::vector<TYPE*> m_vector;
 };
 
-#endif
+#endif  // CORE_SRC_FXCODEC_JBIG2_JBIG2_LIST_H_