Put CJBig2_SymbolDict's images in a CJBig2_List container.

Put CJBig2_SymbolDict's images in a CJBig2_List container.

Also mark it private.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/8793b4a071fad51a770b93838e0752505b020e43

[Lei Zhang, 2015-10-07 18:14:19]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2015-10-07 19:20:01]

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
File core/src/fxcodec/jbig2/JBig2_Context.cpp (right):

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_Context.cpp:730: nonstd::unique_ptr<CJBig2_Image*,
FxFreeDeleter> SBSYMS;
should this and pTURD->SBSYMS be list<>s as well?

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
File core/src/fxcodec/jbig2/JBig2_List.h (right):

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_List.h:7: #ifndef
CORE_SRC_FXCODEC_JBIG2_JBIG2_LIST_H_
nit: maybe add a comment here that this is a vector of pointers that owns (and
deletes) all its elements.

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_List.h:21: void clear() {
nit: Codesearch says this is called only from dtor; please confirm and move into
dtor itself.

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_List.h:24: m_vector.clear();
nit: at which point the .clear() becomes pointless in dtor.

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_List.h:33: 
need a set method here so we can do more that just push onto the back?

[Lei Zhang, 2015-10-08 04:41:04]

Patchset #2 (id:20001) has been deleted

[Lei Zhang, 2015-10-08 04:52:04]

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
File core/src/fxcodec/jbig2/JBig2_Context.cpp (right):

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_Context.cpp:730: nonstd::unique_ptr<CJBig2_Image*,
FxFreeDeleter> SBSYMS;
On 2015/10/07 19:20:01, Tom Sepez wrote:
> should this and pTURD->SBSYMS be list<>s as well?

No, |dict| below owns the images. |SBSYMS| does not.

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
File core/src/fxcodec/jbig2/JBig2_List.h (right):

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_List.h:7: #ifndef
CORE_SRC_FXCODEC_JBIG2_JBIG2_LIST_H_
On 2015/10/07 19:20:01, Tom Sepez wrote:
> nit: maybe add a comment here that this is a vector of pointers that owns (and
> deletes) all its elements.

Done.

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_List.h:21: void clear() {
On 2015/10/07 19:20:01, Tom Sepez wrote:
> nit: Codesearch says this is called only from dtor; please confirm and move
into
> dtor itself.

clear() corresponds to vector::clear(). We may find a use for it later.

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_List.h:24: m_vector.clear();
On 2015/10/07 19:20:01, Tom Sepez wrote:
> nit: at which point the .clear() becomes pointless in dtor.

But it's ok as is.

https://codereview.chromium.org/1395613003/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_List.h:33: 
On 2015/10/07 19:20:01, Tom Sepez wrote:
> need a set method here so we can do more that just push onto the back?

Maybe later when needed? Or do you prefer I use it in this CL?

[Tom Sepez, 2015-10-08 18:35:20]

lgtm

[Lei Zhang, 2015-10-08 19:13:13]

Committed patchset #4 (id:80001) manually as
8793b4a071fad51a770b93838e0752505b020e43 (presubmit successful).