Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1395583004: Revert of Don't compile functions in a context the caller doesn't have access to (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Don't compile functions in a context the caller doesn't have access to (patchset #1 id:1 of https://codereview.chromium.org/1393713006/ ) Reason for revert: [Sheriff] Breaks layout tests. Please add needsmanualrebaseline upstream first if intended. E.g.: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/2263 (one of them is a timeout that only happens with this commit) Original issue's description: > Don't compile functions in a context the caller doesn't have access to > > Instead, just return undefined. > > A side effect of this is that it's no longer possible to compile > functions in a detached context. > > Based on https://codereview.chromium.org/294073002 but taking access > check callbacks into account > > BUG=chromium:541703 > R=verwaest@chromium.org > LOG=y > > Committed: https://crrev.com/9a5e2f512c4aa90563eb575605c2a8c2a92ac9f4 > Cr-Commit-Position: refs/heads/master@{#31208} TBR=verwaest@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:541703 Committed: https://crrev.com/fe6ff6523e3bed2d139ac551ba55cc5d8f086f0e Cr-Commit-Position: refs/heads/master@{#31212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -219 lines) Patch
M src/d8.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/generator.js View 1 chunk +1 line, -3 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +0 lines, -58 lines 0 comments Download
M src/v8natives.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +1 line, -76 lines 0 comments Download
M test/mjsunit/cross-realm-filtering.js View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of Don't compile functions in a context the caller doesn't have access to
5 years, 2 months ago (2015-10-12 14:15:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395583004/1
5 years, 2 months ago (2015-10-12 14:35:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 14:35:46 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 14:36:10 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe6ff6523e3bed2d139ac551ba55cc5d8f086f0e
Cr-Commit-Position: refs/heads/master@{#31212}

Powered by Google App Engine
This is Rietveld 408576698