Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294073002: filter cross context eval (Closed)

Created:
6 years, 7 months ago by dcarney
Modified:
6 years, 3 months ago
Reviewers:
Toon Verwaest, yurys
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 3

Patch Set 3 : rebase fix #

Patch Set 4 : rebase #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 1

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -2 lines) Patch
M src/generator.js View 1 chunk +3 lines, -1 line 0 comments Download
M src/runtime.cc View 1 2 3 4 5 6 7 2 chunks +58 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
M test/mjsunit/cross-realm-filtering.js View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dcarney
ptal (when you get back)
6 years, 7 months ago (2014-05-20 14:37:56 UTC) #1
Toon Verwaest
https://codereview.chromium.org/294073002/diff/20001/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/294073002/diff/20001/src/runtime.cc#newcode9794 src/runtime.cc:9794: for (int i = frames.length() - 1; i >= ...
6 years, 7 months ago (2014-05-27 15:15:43 UTC) #2
dcarney
https://codereview.chromium.org/294073002/diff/20001/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/294073002/diff/20001/src/runtime.cc#newcode9794 src/runtime.cc:9794: for (int i = frames.length() - 1; i >= ...
6 years, 7 months ago (2014-05-27 15:45:11 UTC) #3
Toon Verwaest
lgtm
6 years, 6 months ago (2014-05-28 10:48:06 UTC) #4
yurys
This will break the following test which seems fine to me: <html> <head> <script> function ...
6 years, 6 months ago (2014-05-28 12:19:02 UTC) #5
dcarney
okay, i think everything is fixed. ptal
6 years, 6 months ago (2014-06-03 10:33:13 UTC) #6
Toon Verwaest
lgtm with nit https://codereview.chromium.org/294073002/diff/110001/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/294073002/diff/110001/src/runtime.cc#newcode9797 src/runtime.cc:9797: Handle<Context> context = handle(callee.ToHandleChecked()->context()); remove " ...
6 years, 6 months ago (2014-06-11 12:28:45 UTC) #7
dcarney
Committed patchset #8 manually as r21793.
6 years, 6 months ago (2014-06-12 08:28:32 UTC) #8
Toon Verwaest
6 years, 3 months ago (2014-09-18 17:22:03 UTC) #9
Message was sent while issue was closed. 
This breaks setting the domain after the fact. See
https://code.google.com/p/chromium/issues/detail?id=415051. Reverting until we
can come up with a working solution.

Powered by Google App Engine
This is Rietveld 408576698