chrome/test/BUILD.gn - Issue 1395573003: Build nacl_helper_nonsfi with GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/BUILD.gn

Issue 1395573003: Build nacl_helper_nonsfi with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Set cflags locally rather than globally Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/BUILD.gn

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn

index adb114f1a6bc5af54446dc0cf7bfc5f3c3271263..b1cc7dc3ee71879b1bd24870c58d5318edb5c79b 100644

--- a/chrome/test/BUILD.gn

+++ b/chrome/test/BUILD.gn

@@ -425,7 +425,7 @@ if (!is_android) {

if (enable_nacl) {

deps += [

"//components/nacl:nacl_helper",

- # '../components/nacl_nonsfi.gyp:nacl_helper_nonsfi', TODO(GYP)

+ "//components/nacl:nacl_helper_nonsfi",

]

}

@@ -967,7 +967,7 @@ if (!is_android) {

if (is_linux) {

data_deps += [

"//components/nacl:nacl_helper",

- # "//components/nacl_nonsfi.gyp:nacl_helper_nonsfi", # TODO(GYP) bug 512912.

+ "//components/nacl:nacl_helper_nonsfi(//build/toolchain/nacl:newlib_pnacl_nonsfi)",

]

}