Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1395563005: Increase Dart's github polling interval, especially for client.dart.packages. (Closed)

Created:
5 years, 2 months ago by Bill Hesse
Modified:
5 years, 2 months ago
Reviewers:
ricow1
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Increase Dart's github polling interval, especially for client.dart.packages. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297078

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M masters/master.client.dart.packages/master.cfg View 1 2 chunks +7 lines, -3 lines 0 comments Download
M masters/master.client.dart/master.cfg View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/master/factory/dart/dart_factory.py View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bill Hesse
5 years, 2 months ago (2015-10-09 10:59:47 UTC) #2
ricow1
lgtm with suggestion https://codereview.chromium.org/1395563005/diff/1/masters/master.client.dart.packages/master.cfg File masters/master.client.dart.packages/master.cfg (right): https://codereview.chromium.org/1395563005/diff/1/masters/master.client.dart.packages/master.cfg#newcode126 masters/master.client.dart.packages/master.cfg:126: interval += 10; +3 instead to ...
5 years, 2 months ago (2015-10-09 11:25:54 UTC) #3
Bill Hesse
On 2015/10/09 11:25:54, ricow1 wrote: > lgtm with suggestion > > https://codereview.chromium.org/1395563005/diff/1/masters/master.client.dart.packages/master.cfg > File masters/master.client.dart.packages/master.cfg ...
5 years, 2 months ago (2015-10-09 11:39:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395563005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395563005/20001
5 years, 2 months ago (2015-10-09 11:39:29 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 11:42:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297078

Powered by Google App Engine
This is Rietveld 408576698