Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3223)

Unified Diff: scripts/master/factory/dart/dart_factory.py

Issue 1395563005: Increase Dart's github polling interval, especially for client.dart.packages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Address comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « masters/master.client.dart/master.cfg ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/factory/dart/dart_factory.py
diff --git a/scripts/master/factory/dart/dart_factory.py b/scripts/master/factory/dart/dart_factory.py
index b2ebbd8ac66efd91de7db564f0da3889949f40ea..028ebfe045e1b8e16087c344b13a49d64934fb7b 100644
--- a/scripts/master/factory/dart/dart_factory.py
+++ b/scripts/master/factory/dart/dart_factory.py
@@ -546,13 +546,15 @@ class DartUtils(object):
@staticmethod
- def get_git_poller(repo, project, revlink, branch=None, master=None):
+ def get_git_poller(repo, project, revlink, branch=None, master=None,
+ interval=None):
project = '%s-%s' % (project, branch) if branch else project
branch = branch or 'master'
master = master or 'main'
+ interval = interval or 40
workdir = '/tmp/git_workdir_%s_%s_%s' % (project, branch, master)
return gitpoller.GitPoller(repourl=repo,
- pollinterval=20,
+ pollinterval=interval,
project=project,
branch=branch,
workdir=workdir,
@@ -570,10 +572,11 @@ class DartUtils(object):
return 'https://github.com/%s/%s.git' % (project, name)
@staticmethod
- def get_github_poller(project, name, branch=None, master=None):
+ def get_github_poller(project, name, branch=None, master=None, interval=None):
repository = 'https://github.com/%s/%s.git' % (project, name)
revlink = ('https://github.com/' + project + '/' + name + '/commit/%s')
- return DartUtils.get_git_poller(repository, name, revlink, branch, master)
+ return DartUtils.get_git_poller(repository, name, revlink, branch, master,
+ interval=interval)
@staticmethod
def get_github_mirror_poller(project, name, branch=None, master=None):
« no previous file with comments | « masters/master.client.dart/master.cfg ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698