Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1395493008: Revert of Oilpan: always shrink tail-allocated backing storage. (Closed)

Created:
5 years, 2 months ago by Yuta Kitamura
Modified:
5 years, 2 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
chromium-reviews, oilpan-reviews, blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Oilpan: always shrink tail-allocated backing storage. (patchset #2 id:20001 of https://codereview.chromium.org/1393863004/ ) Reason for revert: Suspect that this change has caused assertion failures on Oilpan+Windows+Debug bot. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20%28dbg%29/builds/2955 (Builds are purple because they quit early due to too many crashes.) Crash logs look like: 02:49:04.570 1008 ASSERTION FAILED: header->payloadSize() > newSize 02:49:04.570 1008 Backtrace: 02:49:04.570 1008 blink::NormalPageHeap::shrinkObject [0x084A1504+148] 02:49:04.570 1008 blink::HeapAllocator::backingShrink [0x0849AE8A+394] 02:49:04.570 1008 blink::HeapAllocator::shrinkVectorBacking [0x0849B064+20] 02:49:04.570 1008 WTF::VectorBuffer<blink::Member<blink::Node>,0,blink::HeapAllocator>::shrinkBuffer [0x189E87A6+134] 02:49:04.570 1008 WTF::Vector<blink::Member<blink::Node>,0,blink::HeapAllocator>::shrinkCapacity [0x189E8BA6+102] 02:49:04.570 1008 WTF::Vector<blink::Member<blink::Node>,0,blink::HeapAllocator>::shrinkToFit [0x19A6E65F+31] 02:49:04.570 1008 blink::DistributedNodes::shrinkToFit [0x19A6E686+22] (snip) Original issue's description: > Oilpan: always shrink tail-allocated backing storage. > > When shrinking backing storage allocations, some care is taken not to > introduce excessive fragmentation and/or limit later expansion of the > same object. That logic does not need to apply if the backing store is > at the tail of the current heap chunk: unconditionally reset the > allocation point, if it is. > > R=haraken > BUG=420515 > > Committed: https://crrev.com/afa3e61596ebb5d648a6e9923de85534926d27fa > Cr-Commit-Position: refs/heads/master@{#353321} TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420515 Committed: https://crrev.com/af6c2e38c9f3928c1472c6d070780894f5ed39e7 Cr-Commit-Position: refs/heads/master@{#354243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapAllocator.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yuta Kitamura
Created Revert of Oilpan: always shrink tail-allocated backing storage.
5 years, 2 months ago (2015-10-15 09:54:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395493008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395493008/1
5 years, 2 months ago (2015-10-15 09:54:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 09:55:37 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/af6c2e38c9f3928c1472c6d070780894f5ed39e7 Cr-Commit-Position: refs/heads/master@{#354243}
5 years, 2 months ago (2015-10-15 09:56:33 UTC) #4
haraken
LGTM, thanks for the revert!
5 years, 2 months ago (2015-10-15 10:27:32 UTC) #5
sof
lgtm, odd assert - newSize equal to the payload size?
5 years, 2 months ago (2015-10-15 10:47:19 UTC) #6
sof
On 2015/10/15 10:47:19, sof wrote: > lgtm, odd assert - newSize equal to the payload ...
5 years, 2 months ago (2015-10-16 07:04:41 UTC) #7
haraken
5 years, 2 months ago (2015-10-16 07:07:38 UTC) #8
Message was sent while issue was closed.
On 2015/10/16 07:04:41, sof wrote:
> On 2015/10/15 10:47:19, sof wrote:
> > lgtm, odd assert - newSize equal to the payload size?
> 
> that was it; added the check.

Where is your new CL?

Powered by Google App Engine
This is Rietveld 408576698