Increase Web Notification timeout to 20 seconds

Increase Web Notification timeout to 20 seconds

Data from partners suggests this improves re-engagement. We intend to
revisit this in m48 with a Finch experiment.

BUG=530697
Committed: https://crrev.com/07e31a310e07d3aa8a07c45670e70e89094317b7
Cr-Commit-Position: refs/heads/master@{#352904}

[johnme, 2015-10-07 12:25:19]

johnme@chromium.org changed reviewers:
+ dewittj@chromium.org

[dewittj, 2015-10-07 17:56:40]

lgtm

One possibility is to rename is_web_notification to use_long_timeouts (something
that describes what the flag does)

https://codereview.chromium.org/1395483002/diff/1/ui/message_center/popup_tim...
File ui/message_center/popup_timer.cc (right):

https://codereview.chromium.org/1395483002/diff/1/ui/message_center/popup_tim...
ui/message_center/popup_timer.cc:24: return base::TimeDelta::FromSeconds(20);
please add a constant to message_center_style.h instead of 20 here

[johnme, 2015-10-07 18:18:06]

Addressed review comments - thanks :)

On 2015/10/07 17:56:40, dewittj wrote:
> One possibility is to rename is_web_notification to use_long_timeouts
(something
> that describes what the flag does)

I've kept is_web_notification for now, since other chrome components probably
shouldn't rely on this yet, as we're about to use Finch to vary the timeout.

https://codereview.chromium.org/1395483002/diff/1/ui/message_center/popup_tim...
File ui/message_center/popup_timer.cc (right):

https://codereview.chromium.org/1395483002/diff/1/ui/message_center/popup_tim...
ui/message_center/popup_timer.cc:24: return base::TimeDelta::FromSeconds(20);
On 2015/10/07 17:56:40, dewittj wrote:
> please add a constant to message_center_style.h instead of 20 here

Done.

[johnme, 2015-10-07 18:18:22]

The CQ bit was checked by johnme@chromium.org

[johnme, 2015-10-07 18:18:22]

The patchset sent to the CQ was uploaded after l-g-t-m from dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/1395483002/#ps20001
(title: "Use constant for delay")

[commit-bot: I haz the power, 2015-10-07 18:19:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395483002/20001

[commit-bot: I haz the power, 2015-10-07 19:14:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-07 19:15:01]

Patchset 2 (id:??) landed as
https://crrev.com/07e31a310e07d3aa8a07c45670e70e89094317b7
Cr-Commit-Position: refs/heads/master@{#352904}

[Peter Beverloo, 2015-10-08 07:23:06]

peter@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2015-10-08 07:23:06]

Thank you for picking this up!

https://codereview.chromium.org/1395483002/diff/20001/ui/message_center/notif...
File ui/message_center/notification.h (right):

https://codereview.chromium.org/1395483002/diff/20001/ui/message_center/notif...
ui/message_center/notification.h:202: optional_fields_.is_web_notification =
is_web_notification;
why can't we use notifier_id_type==NotifierId::WEB_PAGE?

[Peter Beverloo, 2015-10-08 07:25:02]

On 2015/10/08 07:23:06, Peter Beverloo wrote:
> Thank you for picking this up!
> 
>
https://codereview.chromium.org/1395483002/diff/20001/ui/message_center/notif...
> File ui/message_center/notification.h (right):
> 
>
https://codereview.chromium.org/1395483002/diff/20001/ui/message_center/notif...
> ui/message_center/notification.h:202: optional_fields_.is_web_notification =
> is_web_notification;
> why can't we use notifier_id_type==NotifierId::WEB_PAGE?

(aside from the two features which seem to be using this wrongly :/)