ui/message_center/message_center_style.cc - Issue 1395483002: Increase Web Notification timeout to 20 seconds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/message_center_style.cc

Issue 1395483002: Increase Web Notification timeout to 20 seconds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use constant for delay Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/message_center/message_center_style.cc

diff --git a/ui/message_center/message_center_style.cc b/ui/message_center/message_center_style.cc

index 3413149effbe0680678a1486cd948ec723165978..33f875796c5f0c75485cb681f525d03a7b8fb115 100644

--- a/ui/message_center/message_center_style.cc

+++ b/ui/message_center/message_center_style.cc

@@ -54,6 +54,10 @@ const size_t kNotificationMaximumItems = 5;

// Timing.

const int kAutocloseDefaultDelaySeconds = 8;

const int kAutocloseHighPriorityDelaySeconds = 25;

+// Web notifications use a larger timeout for now, which improves re-engagement.

+// TODO(johnme): Use Finch to experiment with different values for this, then

+// consider replacing kAutocloseDefaultDelaySeconds with this.

+const int kAutocloseWebNotificationDelaySeconds = 20;

// Colors.

const SkColor kBackgroundLightColor = SkColorSetRGB(0xf1, 0xf1, 0xf1);