Follow-up clean-up in LoginHandler

Follow-up clean-up in LoginHandler

This CL addresses post-landing comments of https://codereview.chromium.org/1384283003/.

BUG=537823
Committed: https://crrev.com/29b714103cae29c0f1f17d49cdababb1a68b3df3
Cr-Commit-Position: refs/heads/master@{#353244}

[vabr (Chromium), 2015-10-08 09:24:34]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-08 09:25:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395473003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395473003/1

[commit-bot: I haz the power, 2015-10-08 10:13:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-08 10:13:44]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2015-10-08 10:23:34]

vabr@chromium.org changed reviewers:
+ davidben@chromium.org, pkasting@chromium.org

[vabr (Chromium), 2015-10-08 10:23:34]

David, Peter,

Here come your comments from https://codereview.chromium.org/1384283003/
addressed, PTAL.

Thanks for your help!
Vaclav

https://codereview.chromium.org/1395473003/diff/1/chrome/browser/ui/login/log...
File chrome/browser/ui/login/login_prompt.cc (left):

https://codereview.chromium.org/1395473003/diff/1/chrome/browser/ui/login/log...
chrome/browser/ui/login/login_prompt.cc:74: std::string GetSignonRealm(const
GURL& url,
This whole method just got moved without changes to the end of the file, the
Public API section.

https://codereview.chromium.org/1395473003/diff/1/chrome/browser/ui/login/log...
File chrome/browser/ui/login/login_prompt.cc (right):

https://codereview.chromium.org/1395473003/diff/1/chrome/browser/ui/login/log...
chrome/browser/ui/login/login_prompt.cc:69: PasswordForm
MakeInputForPasswordManager(const GURL& request_url,
This and the following methods have just been moved. The only exception is a
change noted below, otherwise the code was unchanged.

https://codereview.chromium.org/1395473003/diff/1/chrome/browser/ui/login/log...
chrome/browser/ui/login/login_prompt.cc:94: return dialog_form;
The handler->SetPasswordForm(dialog_form); call before the return has been
pulled out to the callsite. The |handler| argument was dropped.

[davidben, 2015-10-08 15:33:51]

lgtm

https://codereview.chromium.org/1395473003/diff/1/chrome/browser/ui/login/log...
File chrome/browser/ui/login/login_prompt.cc (right):

https://codereview.chromium.org/1395473003/diff/1/chrome/browser/ui/login/log...
chrome/browser/ui/login/login_prompt.cc:218: SetPasswordForm(observed_form);
These two methods no longer need to be public and can just be replaced by
setting password_form_ and password_manager_ I think.

[vabr (Chromium), 2015-10-08 15:56:19]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[vabr (Chromium), 2015-10-08 15:56:41]

Thanks, David!
Comment addressed.
Cheers,
Vaclav

https://codereview.chromium.org/1395473003/diff/1/chrome/browser/ui/login/log...
File chrome/browser/ui/login/login_prompt.cc (right):

https://codereview.chromium.org/1395473003/diff/1/chrome/browser/ui/login/log...
chrome/browser/ui/login/login_prompt.cc:218: SetPasswordForm(observed_form);
On 2015/10/08 15:33:51, David Benjamin wrote:
> These two methods no longer need to be public and can just be replaced by
> setting password_form_ and password_manager_ I think.

Good call!
Done.

[commit-bot: I haz the power, 2015-10-08 15:57:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395473003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395473003/20001

[commit-bot: I haz the power, 2015-10-08 16:41:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-08 16:41:28]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2015-10-08 21:26:47]

LGTM

[vabr (Chromium), 2015-10-09 07:11:17]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2015-10-09 07:11:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/1395473003/#ps20001
(title: "Remove accessors")

[commit-bot: I haz the power, 2015-10-09 07:12:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395473003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395473003/20001

[commit-bot: I haz the power, 2015-10-09 07:18:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-09 07:19:51]

Patchset 2 (id:??) landed as
https://crrev.com/29b714103cae29c0f1f17d49cdababb1a68b3df3
Cr-Commit-Position: refs/heads/master@{#353244}