Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1395473003: Follow-up clean-up in LoginHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove accessors Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/login_prompt_views.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 3529e88657ea53cf9dd9de2a9252978f15a6baf0..d55849868e5d709f64fa1ef477a50333bf2f691e 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -403,6 +403,9 @@ void PasswordManager::AddObserverAndDeliverCredentials(
observers_.AddObserver(observer);
observer->set_signon_realm(observed_form.signon_realm);
+ // TODO(vabr): Even though the observers do the realm check, this mechanism
+ // will still result in every observer being notified about every form. We
+ // could perhaps do better by registering an observer call-back instead.
std::vector<PasswordForm> observed_forms;
observed_forms.push_back(observed_form);
« no previous file with comments | « chrome/browser/ui/views/login_prompt_views.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698