chrome/browser/ui/webui/web_ui_test_handler.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/web_ui_test_handler.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc ('k') | chrome/common/local_discovery/local_domain_resolver_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/web_ui_test_handler.cc

diff --git a/chrome/browser/ui/webui/web_ui_test_handler.cc b/chrome/browser/ui/webui/web_ui_test_handler.cc

index d4e03aabba7aa0e4ab592b4240a8a8ca67d6bae6..a249c1ee9bf93c481b1c5acf796c0a1554f170be 100644

--- a/chrome/browser/ui/webui/web_ui_test_handler.cc

+++ b/chrome/browser/ui/webui/web_ui_test_handler.cc

@@ -61,7 +61,7 @@ void WebUITestHandler::HandleTestResult(const base::ListValue* test_result) {

// Quit the message loop if |is_waiting_| so waiting process can get result or

// error. To ensure this gets done, do this before ASSERT* calls.

if (is_waiting_)

- base::MessageLoopForUI::current()->Quit();

+ base::MessageLoopForUI::current()->QuitWhenIdle();

SCOPED_TRACE("WebUITestHandler::HandleTestResult");

@@ -81,7 +81,7 @@ void WebUITestHandler::JavaScriptComplete(const base::Value* result) {

// Quit the message loop if |is_waiting_| so waiting process can get result or

// error. To ensure this gets done, do this before ASSERT* calls.

if (is_waiting_)

- base::MessageLoopForUI::current()->Quit();

+ base::MessageLoopForUI::current()->QuitWhenIdle();

SCOPED_TRACE("WebUITestHandler::JavaScriptComplete");