chrome/browser/ui/webui/bidi_checker_web_ui_test.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/website_settings/mock_permission_bubble_view.cc ('k') | chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

diff --git a/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc b/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

index 522c3e6f7905caa26663f2f4c6c1724f40eeaf3e..cb83a4d88f96c7780a07b04da147581618ac14ac 100644

--- a/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

+++ b/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

@@ -69,10 +69,9 @@ void ReloadLocaleResourcesOnIOThread(const std::string& new_locale) {

// crbug.com/95425, crbug.com/132752

void ReloadLocaleResources(const std::string& new_locale) {

content::BrowserThread::PostTaskAndReply(

- content::BrowserThread::IO,

- FROM_HERE,

+ content::BrowserThread::IO, FROM_HERE,

base::Bind(&ReloadLocaleResourcesOnIOThread, base::ConstRef(new_locale)),

- base::MessageLoop::QuitClosure());

+ base::MessageLoop::QuitWhenIdleClosure());

content::RunMessageLoop();

}