chrome/browser/ui/website_settings/mock_permission_bubble_view.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/mock_permission_bubble_view.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/website_settings/mock_permission_bubble_view.cc

diff --git a/chrome/browser/ui/website_settings/mock_permission_bubble_view.cc b/chrome/browser/ui/website_settings/mock_permission_bubble_view.cc

index 7406d132f003be670480a6922a9369a5cf568594..f4436d65aa4f4203f05d9f202f9f60eeb6eca263 100644

--- a/chrome/browser/ui/website_settings/mock_permission_bubble_view.cc

+++ b/chrome/browser/ui/website_settings/mock_permission_bubble_view.cc

@@ -54,7 +54,7 @@ void MockPermissionBubbleView::Show(

permission_requests_ = requests;

permission_states_ = accept_state;

if (browser_test_)

- base::MessageLoopForUI::current()->Quit();

+ base::MessageLoopForUI::current()->QuitWhenIdle();

}

void MockPermissionBubbleView::Hide() {

« no previous file with comments | « chrome/browser/ui/views/web_dialog_view_browsertest.cc ('k') | chrome/browser/ui/webui/bidi_checker_web_ui_test.cc » ('j') | no next file with comments »