chrome/browser/safe_browsing/download_protection_service_unittest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_service_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_protection_service_unittest.cc b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

index cd27712f50375a0af74f718dea7ce5121f8fb9a9..2606c2f8d6a97058dd2c7b93023885167a91ea53 100644

--- a/chrome/browser/safe_browsing/download_protection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/download_protection_service_unittest.cc

@@ -343,9 +343,7 @@ class DownloadProtectionServiceTest : public testing::Test {

base::Unretained(this)));

}

- void QuitMessageLoop() {

- base::MessageLoop::current()->Quit();

- }

+ void QuitMessageLoop() { base::MessageLoop::current()->QuitWhenIdle(); }

void PostRunMessageLoopTask(BrowserThread::ID thread) {

BrowserThread::PostTask(

@@ -377,7 +375,7 @@ class DownloadProtectionServiceTest : public testing::Test {

DownloadProtectionService::DownloadCheckResult result) {

result_ = result;

has_result_ = true;

- MessageLoop::current()->Quit();

+ MessageLoop::current()->QuitWhenIdle();

}

void SyncCheckDoneCallback(